Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Patch 3 - typo fix by copy rewrite #9783

Merged
merged 2 commits into from Feb 7, 2020
Merged

Conversation

seantcoyote
Copy link

@seantcoyote seantcoyote commented Feb 7, 2020

If reviewers don't agree that my proposed copy rewrite is an improvement, let's at least add the missing 'are': so, "Sometimes these are used..." instead of "Sometimes these used..."

Issue:

What I did

Fixed typo (missing word) and unclear sentence by rewriting in a more direct voice.

How to test

Documentation only.

If reviewers don't think my proposed copy rewrite is accurate or sufficient, let's at least add the missing 'are':
@dangreenisrael
Copy link
Member

Looks like your base branch may be out of date, or perhaps you based off of the wrong branch?

@shilman shilman changed the base branch from next to master February 7, 2020 02:39
Copy link
Member

@shilman shilman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @seantcoyote !! Definitely much better 💯

@shilman shilman added documentation patch:yes Bugfix & documentation PR that need to be picked to main branch labels Feb 7, 2020
@shilman shilman merged commit 0959818 into storybookjs:master Feb 7, 2020
@shilman shilman added the patch:done Patch/release PRs already cherry-picked to main/release branch label Feb 13, 2020
shilman added a commit that referenced this pull request Feb 13, 2020
Patch 3 - typo fix by copy rewrite
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation patch:done Patch/release PRs already cherry-picked to main/release branch patch:yes Bugfix & documentation PR that need to be picked to main branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants