import react-syntax-highlighter/create-element from cjs #9795
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I forgot to change the import for create-element |
This was referenced Feb 8, 2020
|
Is there any chance this fix could get released as a patch for v5.3 as well? |
|
@tay1orjones @alexandrzavalii if a few people can verify that it's solving the problem well in 6.0, i'd be happy to patch it back to 5.3 for you. |
|
@shilman @tay1orjones can you please verify alpha and let us know if it works for you? |
|
Thanks @alexandrzavalii !! |
|
@alexandrzavalii @shilman Yes, this works for me as well on |
|
Coming soon! Thanks for testing guys!!! |
tay1orjones
added a commit
to carbon-design-system/carbon-addons-iot-react
that referenced
this pull request
Feb 24, 2020
this fixes an error present due to the esm import when updating to storybook 5.3.13 storybookjs/storybook#9470 (comment) this has a fix in v6, but is currently in alpha, it's possible a patch for 5.3 could be released storybookjs/storybook#9795 (comment) either way, this can be removed in the future
shilman
added
the
patch:yes
shilman
added
the
patch:done
shilman
added a commit
that referenced
this pull request
Mar 14, 2020
…r_cjs import react-syntax-highlighter/create-element from cjs
shilman
removed
patch:yes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: #9279
This pr is the copy of #9780
Looks like create-element should also be imported from cjs
What I did
This is a splited task from #9292
Changed imports from ESModules to CommonJS modules for react-syntax-highlighter.
How to test
Nothing to test