Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move storybook packages to peer deps #101

Merged
merged 2 commits into from
Apr 28, 2022
Merged

Move storybook packages to peer deps #101

merged 2 commits into from
Apr 28, 2022

Conversation

IanVS
Copy link
Member

@IanVS IanVS commented Apr 27, 2022

I had a test failure begin in storybookjs/builder-vite#357 when updating the test-runner to anything higher than 0.0.5-next.0. I traced it down to the test-runner installing and using a 6.4 version of @storybook/store, while my storybook project is on 6.5.0-beta.0.

I think this change is the correct way to handle this, by moving the storybook projects to peerDependencies, with a range that includes 6.5.0 pre-releases. Any other approach risks installing a different version for the test runner than what is installed in the main project.

πŸ“¦ Published PR as canary version: 0.0.8-canary.101.df0a2dc.0

✨ Test out this PR locally via:

npm install @storybook/test-runner@0.0.8-canary.101.df0a2dc.0
# or 
yarn add @storybook/test-runner@0.0.8-canary.101.df0a2dc.0

Version

Published prerelease version: v0.0.8-next.1

Changelog

πŸ› Bug Fix

πŸ“ Documentation

  • Document limitation for .mdx stories #102 (@IanVS)

Authors: 3

@IanVS
Copy link
Member Author

IanVS commented Apr 27, 2022

Using this canary, I get yarn warnings like

YN0002: β”‚ example-react@workspace:examples/react doesn't provide @storybook/store (p38ca6), requested by @storybook/test-runner

in my project, but it's no longer breaking the tests. It seems like yarn peer dependencies don't consider transitive deps. Or maybe it's a workspaces issue.

@IanVS IanVS requested review from yannbf and shilman and removed request for yannbf April 27, 2022 19:03
@yannbf yannbf added the patch Increment the patch version when merged label Apr 28, 2022
@yannbf
Copy link
Member

yannbf commented Apr 28, 2022

Thanks @IanVS !! LGTM

@yannbf yannbf merged commit 63d9491 into next Apr 28, 2022
@yannbf yannbf mentioned this pull request Apr 28, 2022
@yannbf yannbf deleted the storybook-peer-deps branch November 18, 2022 14:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
patch Increment the patch version when merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants