Make setup-page globally available for index.json mode compatibility #217
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Nov 9, 2022
shilman
reviewed
Nov 9, 2022
yannbf
added a commit
that referenced
this pull request
Nov 18, 2022
Make setup-page globally available for index.json mode compatibility
Merged
This was referenced Feb 1, 2023
This was referenced Mar 6, 2023
Merged
Merged
|
馃殌 PR was released in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: #136
This PR removes usage of
globalpackage and usesglobalThisinstead, which makes the retrying mechanism of the test-runner work in index.json (or stories.json) mode.Additionally, it provides a log message to warn users that the story of which needs a retry, probably has done a navigation.
Version
Published prerelease version:
v0.10.0-next.2Changelog
馃殌 Enhancement
馃悰 Bug Fix
馃摑 Documentation
Authors: 3