Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CLI: Add explicit dependencies on used plugins #1652

Merged
merged 5 commits into from
Aug 17, 2017
Merged

Conversation

Hypnosphi
Copy link
Member

Stop muting eslint rules that were warning about their absense

@Hypnosphi
Copy link
Member Author

Looks like I should get versions of each addon independently

Copy link
Member

@ndelangen ndelangen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code LGTM

Not tested

@codecov
Copy link

codecov bot commented Aug 16, 2017

Codecov Report

Merging #1652 into master will increase coverage by 0.55%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1652      +/-   ##
==========================================
+ Coverage   20.57%   21.13%   +0.55%     
==========================================
  Files         247      247              
  Lines        5554     5582      +28     
  Branches      667      668       +1     
==========================================
+ Hits         1143     1180      +37     
+ Misses       3902     3897       -5     
+ Partials      509      505       -4
Impacted Files Coverage Δ
addons/storyshots/src/storybook-channel-mock.js 0% <0%> (ø) ⬆️
addons/storyshots/src/require_context.js 0% <0%> (ø) ⬆️
addons/events/src/components/Event.js 0% <0%> (ø) ⬆️
...react-native/src/manager/components/PreviewHelp.js 0% <0%> (ø) ⬆️
app/react/src/client/preview/error_display.js 0% <0%> (ø) ⬆️
lib/ui/src/modules/ui/libs/hierarchy.js 45.45% <0%> (ø) ⬆️
addons/info/src/components/PropTable.js 22.36% <0%> (ø) ⬆️
.../src/manager/containers/CommentsPanel/dataStore.js 34.78% <0%> (ø) ⬆️
addons/knobs/src/react/WrapStory.js 12% <0%> (ø) ⬆️
addons/info/src/components/markdown/code.js 24.13% <0%> (ø) ⬆️
... and 18 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8ab7bda...5c6f426. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants