Deps: Remove core-js from most packages #19098
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
IanVS
force-pushed
the
remove-core-js
branch
2 times, most recently
from
51acd12
to
1a015c7
Compare
They use features which our browserslist thinks needs to be polyfilled. I think these can be removed again once (if?) we move them from babel to esbuild.
IanVS
force-pushed
the
remove-core-js
branch
from
1a015c7
to
4a662b3
Compare
IanVS
changed the title
IanVS
changed the title
shilman
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: core-js is a large dependency, and it may not be needed any longer in storybook 7, given updated node.js and evergreen browser support.
What I did
Removed direct dependencies on core-js from most packages.
Note: there are a handful of packages which still need core-js, but the features they are polyfilling (RegExp.flags, TypedArray.set, seem to be well-supported in our targeted browsers and node-js versions. And we seem to use
setImmediatesomewhere (which is deprecated), so a core-js polyfill for that ends up in@storybook/router.I wonder if the browserslist needs a little tweaking to avoid some of these. And maybe they can be removed entirely once everything is built with TSUP instead of babel.
How to test
CI shouldn't fail.