Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add react18 + webpack5 template #19341

Merged
merged 10 commits into from
Oct 5, 2022
Merged

Conversation

ndelangen
Copy link
Member

Add a template for testing: a custom react app using webpack 5 (react18 + ts)

@ndelangen ndelangen self-assigned this Oct 4, 2022
@ndelangen ndelangen added the build Internal-facing build tooling & test updates label Oct 4, 2022
@tmeasday
Copy link
Member

tmeasday commented Oct 5, 2022

@ndelangen OK, so the issue here is that the preview webpack config includes:

    fallback: {
      path: '/Users/tom/GitHub/storybookjs/storybook/sandbox/react-webpack-18-ts/node_modules/path-browserify/index.js',
      assert: false,
      util: 'util',
      crypto: false
    },

Notice assert: false.

I'm not sure why that's the case in this setup (but not say CRA). It's some interaction between this line:

assert: require.resolve('browser-assert'),

and this one

You no doubt understand better than me the precedence between the two.

I'm not sure why the second one exists, but given it is for this PR that is about the manager, I think it can likely be deleted.

@ndelangen
Copy link
Member Author

@storybookjs/core we need to clean up the webpack config resolution mechanism for 7.0 as part of our breaking changed roadmap.

@ndelangen ndelangen changed the base branch from next to norbert/sb-625-remove-cypress-from-the-monorepo October 5, 2022 07:36
Base automatically changed from norbert/sb-625-remove-cypress-from-the-monorepo to next October 5, 2022 08:10
@ndelangen ndelangen merged commit c15daae into next Oct 5, 2022
@ndelangen ndelangen deleted the norbert/sb-524-webpack5react18ts branch October 5, 2022 10:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build Internal-facing build tooling & test updates
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants