Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix repro templates script #20063

Merged
merged 1 commit into from
Dec 3, 2022
Merged

Fix repro templates script #20063

merged 1 commit into from
Dec 3, 2022

Conversation

valentinpalkovic
Copy link
Contributor

@valentinpalkovic valentinpalkovic commented Dec 2, 2022 •
edited
Loading

What I did

Fix repro templates script to replace all {{beforeDir}} occurrences, not only the first one.

@valentinpalkovic valentinpalkovic added the maintenance User-facing maintenance tasks label Dec 2, 2022
shilman
shilman approved these changes Dec 3, 2022
View reviewed changes
Copy link
Member

@shilman shilman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👀

@shilman shilman merged commit f5dfdb4 into next Dec 3, 2022
@shilman shilman deleted the valentin/fix-repro-templates branch December 3, 2022 01:34
@shilman
Copy link
Member

shilman commented Dec 3, 2022

@valentinpalkovic re-labeling this as build since it's not user-facing

@shilman shilman added build Internal-facing build tooling & test updates and removed maintenance User-facing maintenance tasks labels Dec 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shilman shilman shilman approved these changes

@yannbf yannbf Awaiting requested review from yannbf

@kasperpeulen kasperpeulen Awaiting requested review from kasperpeulen

Assignees
No one assigned
Labels
build Internal-facing build tooling & test updates
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@valentinpalkovic @shilman