Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Extend Angular Zone.js peer dependency range #20107

Merged
merged 3 commits into from
Dec 8, 2022
Merged

Extend Angular Zone.js peer dependency range #20107

merged 3 commits into from
Dec 8, 2022

Conversation

valentinpalkovic
Copy link
Contributor

Issue: #20093

What I did

Extended Angular Zone.js peer dependency range

@valentinpalkovic valentinpalkovic self-assigned this Dec 6, 2022
@shilman shilman added patch:yes Bugfix & documentation PR that need to be picked to main branch angular labels Dec 6, 2022
@valentinpalkovic valentinpalkovic force-pushed the valentin/fix-zone-js-peer-dep-range branch from 9c72d89 to 78ca0b3 Compare December 7, 2022 06:55
@valentinpalkovic valentinpalkovic force-pushed the valentin/fix-zone-js-peer-dep-range branch from 78ca0b3 to 75e57ad Compare December 7, 2022 08:22
shilman
shilman approved these changes Dec 8, 2022
View reviewed changes
Copy link
Member

@shilman shilman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. We could possibly be more strict about only allowing up to the versions we've tested (e.g. < 0.13.0), but I'm fine with the current range.

@shilman shilman merged commit c5674a4 into next Dec 8, 2022
@shilman shilman deleted the valentin/fix-zone-js-peer-dep-range branch December 8, 2022 07:34
@shilman shilman mentioned this pull request Dec 8, 2022
Closed
@kbrilla kbrilla mentioned this pull request Mar 7, 2023
Closed
@shilman shilman added the patch:done Patch/release PRs already cherry-picked to main/release branch label Apr 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shilman shilman shilman approved these changes

@yannbf yannbf Awaiting requested review from yannbf

@kasperpeulen kasperpeulen Awaiting requested review from kasperpeulen

Assignees

@valentinpalkovic valentinpalkovic

Labels
angular bug patch:done Patch/release PRs already cherry-picked to main/release branch patch:yes Bugfix & documentation PR that need to be picked to main branch
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@valentinpalkovic @shilman