Move 'dev'/'build' events to the end of the process #20380
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shilman
approved these changes
Jan 3, 2023
…ild-event-firing-too-early-and
tmeasday
deleted the
tom/sb-1079-fix-devbuild-event-firing-too-early-and
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: N/A
What I did
Move the point where we call out to
'dev'and'build'to be after we know it has "worked".How to test
cd scripts; yarn ts-node ./event-log-collector.ts)bootanddev/build.preview.js(e.g.const = 7;)bootanderror.Note the above won't fail in Vite dev mode, you'd have to be more creative.
Also note, only part 3 for
buildis current tested in CI, would be good to figure out how to change that.