Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Telemetry: Filter out example stories/docs from summary #20553

Merged
merged 3 commits into from
Jan 10, 2023
Merged

Telemetry: Filter out example stories/docs from summary #20553

merged 3 commits into from
Jan 10, 2023

Conversation

shilman
Copy link
Member

@shilman shilman commented Jan 10, 2023 •
edited
Loading

Issue: N/A

Telescoping on #20541

What I did

  • Filter out example IDs
  • Small sanity check in e2e tests

How to test

  • CI passes
  • Manually in a sandbox
STORYBOOK_TELEMETRY_DEBUG=1 yarn storybook

@shilman shilman added maintenance User-facing maintenance tasks telemetry labels Jan 10, 2023
tmeasday
tmeasday approved these changes Jan 10, 2023
View reviewed changes
Copy link
Member

@tmeasday tmeasday left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Base automatically changed from shilman/detect-play-functions to next January 10, 2023 05:56
@shilman shilman marked this pull request as ready for review January 10, 2023 07:20
@shilman shilman merged commit 27ab591 into next Jan 10, 2023
@shilman shilman deleted the shilman/filter-example-stories branch January 10, 2023 09:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tmeasday tmeasday tmeasday approved these changes

Assignees
No one assigned
Labels
maintenance User-facing maintenance tasks telemetry
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@shilman @tmeasday