Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CLI: Remove the deprecated --no-manager-cache flag #20895

Merged
merged 1 commit into from Feb 2, 2023
Merged

Conversation

ndelangen
Copy link
Member

Fixes: #20884

What I did

Remove the CLI flag everywhere

@ndelangen ndelangen self-assigned this Feb 2, 2023
@ndelangen ndelangen added the maintenance User-facing maintenance tasks label Feb 2, 2023
@ndelangen ndelangen changed the title remove --no-manager-cache Remove the deprecated --no-manager-cache CLI flag for start and build Feb 2, 2023
@socket-security
Copy link

Socket Security Pull Request Report

Dependency issues detected. If you merge this pull request, you will not be alerted to the instances of these issues again.

⚠️ Uses eval

Package uses eval() which is a dangerous function. This prevents the code from running in certain environments and increases the risk that the code may contain exploits or malicious behavior.

Avoid packages that use eval, since this could potentially execute any code.

Package Eval Type Location Source
@storybook/components@7.0.0-beta.40 (added) Function dist/formatter-GCLXO5IP.mjs code/addons/a11y/package.json, code/addons/actions/package.json, code/addons/backgrounds/package.json, code/addons/controls/package.json via @storybook/blocks@7.0.0-beta.40, code/addons/docs/package.json via @storybook/blocks@7.0.0-beta.40, code/addons/essentials/package.json via @storybook/addon-actions@7.0.0-beta.40, @storybook/addon-backgrounds@7.0.0-beta.40, @storybook/addon-controls@7.0.0-beta.40, @storybook/addon-docs@7.0.0-beta.40, @storybook/addon-measure@7.0.0-beta.40, @storybook/addon-toolbars@7.0.0-beta.40, @storybook/addon-viewport@7.0.0-beta.40, code/addons/interactions/package.json, code/addons/jest/package.json, code/addons/measure/package.json, code/addons/outline/package.json, code/addons/storyshots-core/package.json via @storybook/addon-docs@7.0.0-beta.40, @storybook/angular@7.0.0-beta.40, code/addons/storysource/package.json, code/addons/toolbars/package.json, code/addons/viewport/package.json, code/frameworks/angular/package.json via @storybook/builder-webpack5@7.0.0-beta.40, code/frameworks/ember/package.json via @storybook/builder-webpack5@7.0.0-beta.40, code/frameworks/html-webpack5/package.json via @storybook/builder-webpack5@7.0.0-beta.40, code/frameworks/nextjs/package.json via @storybook/addon-actions@7.0.0-beta.40, @storybook/builder-webpack5@7.0.0-beta.40, code/frameworks/preact-webpack5/package.json via @storybook/builder-webpack5@7.0.0-beta.40, code/frameworks/react-webpack5/package.json via @storybook/builder-webpack5@7.0.0-beta.40, code/frameworks/server-webpack5/package.json via @storybook/builder-webpack5@7.0.0-beta.40, code/frameworks/svelte-webpack5/package.json via @storybook/builder-webpack5@7.0.0-beta.40, code/frameworks/vue-webpack5/package.json via @storybook/builder-webpack5@7.0.0-beta.40, code/frameworks/vue3-webpack5/package.json via @storybook/builder-webpack5@7.0.0-beta.40, code/frameworks/web-components-webpack5/package.json via @storybook/builder-webpack5@7.0.0-beta.40, code/lib/builder-webpack5/package.json, code/ui/blocks/package.json via @storybook/addon-actions@7.0.0-beta.40, code/ui/manager/package.json
@storybook/components@7.0.0-beta.40 (added) Function dist/formatter-GCLXO5IP.mjs code/addons/a11y/package.json, code/addons/actions/package.json, code/addons/backgrounds/package.json, code/addons/controls/package.json via @storybook/blocks@7.0.0-beta.40, code/addons/docs/package.json via @storybook/blocks@7.0.0-beta.40, code/addons/essentials/package.json via @storybook/addon-actions@7.0.0-beta.40, @storybook/addon-backgrounds@7.0.0-beta.40, @storybook/addon-controls@7.0.0-beta.40, @storybook/addon-docs@7.0.0-beta.40, @storybook/addon-measure@7.0.0-beta.40, @storybook/addon-toolbars@7.0.0-beta.40, @storybook/addon-viewport@7.0.0-beta.40, code/addons/interactions/package.json, code/addons/jest/package.json, code/addons/measure/package.json, code/addons/outline/package.json, code/addons/storyshots-core/package.json via @storybook/addon-docs@7.0.0-beta.40, @storybook/angular@7.0.0-beta.40, code/addons/storysource/package.json, code/addons/toolbars/package.json, code/addons/viewport/package.json, code/frameworks/angular/package.json via @storybook/builder-webpack5@7.0.0-beta.40, code/frameworks/ember/package.json via @storybook/builder-webpack5@7.0.0-beta.40, code/frameworks/html-webpack5/package.json via @storybook/builder-webpack5@7.0.0-beta.40, code/frameworks/nextjs/package.json via @storybook/addon-actions@7.0.0-beta.40, @storybook/builder-webpack5@7.0.0-beta.40, code/frameworks/preact-webpack5/package.json via @storybook/builder-webpack5@7.0.0-beta.40, code/frameworks/react-webpack5/package.json via @storybook/builder-webpack5@7.0.0-beta.40, code/frameworks/server-webpack5/package.json via @storybook/builder-webpack5@7.0.0-beta.40, code/frameworks/svelte-webpack5/package.json via @storybook/builder-webpack5@7.0.0-beta.40, code/frameworks/vue-webpack5/package.json via @storybook/builder-webpack5@7.0.0-beta.40, code/frameworks/vue3-webpack5/package.json via @storybook/builder-webpack5@7.0.0-beta.40, code/frameworks/web-components-webpack5/package.json via @storybook/builder-webpack5@7.0.0-beta.40, code/lib/builder-webpack5/package.json, code/ui/blocks/package.json via @storybook/addon-actions@7.0.0-beta.40, code/ui/manager/package.json
@storybook/manager@7.0.0-beta.40 (added) Function dist/chunk-DMJYHNEY.mjs code/lib/builder-manager/package.json
@storybook/manager@7.0.0-beta.40 (added) Function dist/chunk-DMJYHNEY.mjs code/lib/builder-manager/package.json
@storybook/manager@7.0.0-beta.40 (added) Function dist/chunk-DMJYHNEY.mjs code/lib/builder-manager/package.json
@storybook/manager@7.0.0-beta.40 (added) Function dist/chunk-DMJYHNEY.mjs code/lib/builder-manager/package.json
@storybook/manager@7.0.0-beta.40 (added) Function dist/chunk-DMJYHNEY.mjs code/lib/builder-manager/package.json
@storybook/manager@7.0.0-beta.40 (added) Function dist/chunk-DMJYHNEY.mjs code/lib/builder-manager/package.json
@storybook/manager@7.0.0-beta.40 (added) Function dist/chunk-DMJYHNEY.mjs code/lib/builder-manager/package.json
@storybook/manager@7.0.0-beta.40 (added) Function dist/formatter-GCLXO5IP-SA57GC6A.mjs code/lib/builder-manager/package.json
@storybook/manager@7.0.0-beta.40 (added) Function dist/formatter-GCLXO5IP-SA57GC6A.mjs code/lib/builder-manager/package.json
@storybook/mdx1-csf@1.0.0-next.0 (added) Function dist/index.js code/package.json via @storybook/builder-vite@0.4.0, code/addons/docs/package.json
@storybook/mdx1-csf@1.0.0-next.0 (added) Function dist/index.mjs code/package.json via @storybook/builder-vite@0.4.0, code/addons/docs/package.json
@storybook/preview@7.0.0-beta.40 (added) Function dist/runtime.js code/addons/storyshots-core/package.json via @storybook/angular@7.0.0-beta.40, code/frameworks/angular/package.json via @storybook/builder-webpack5@7.0.0-beta.40, code/frameworks/ember/package.json via @storybook/builder-webpack5@7.0.0-beta.40, code/frameworks/html-vite/package.json via @storybook/builder-vite@7.0.0-beta.40, code/frameworks/html-webpack5/package.json via @storybook/builder-webpack5@7.0.0-beta.40, code/frameworks/nextjs/package.json via @storybook/builder-webpack5@7.0.0-beta.40, code/frameworks/preact-vite/package.json via @storybook/builder-vite@7.0.0-beta.40, code/frameworks/preact-webpack5/package.json via @storybook/builder-webpack5@7.0.0-beta.40, code/frameworks/react-vite/package.json via @storybook/builder-vite@7.0.0-beta.40, code/frameworks/react-webpack5/package.json via @storybook/builder-webpack5@7.0.0-beta.40, code/frameworks/server-webpack5/package.json via @storybook/builder-webpack5@7.0.0-beta.40, code/frameworks/svelte-vite/package.json via @storybook/builder-vite@7.0.0-beta.40, code/frameworks/svelte-webpack5/package.json via @storybook/builder-webpack5@7.0.0-beta.40, code/frameworks/sveltekit/package.json via @storybook/builder-vite@7.0.0-beta.40, @storybook/svelte-vite@7.0.0-beta.40, code/frameworks/vue-vite/package.json via @storybook/builder-vite@7.0.0-beta.40, code/frameworks/vue-webpack5/package.json via @storybook/builder-webpack5@7.0.0-beta.40, code/frameworks/vue3-vite/package.json via @storybook/builder-vite@7.0.0-beta.40, code/frameworks/vue3-webpack5/package.json via @storybook/builder-webpack5@7.0.0-beta.40, code/frameworks/web-components-vite/package.json via @storybook/builder-vite@7.0.0-beta.40, code/frameworks/web-components-webpack5/package.json via @storybook/builder-webpack5@7.0.0-beta.40, code/lib/builder-vite/package.json, code/lib/builder-webpack5/package.json
@storybook/preview@7.0.0-beta.40 (added) Function dist/runtime.js code/addons/storyshots-core/package.json via @storybook/angular@7.0.0-beta.40, code/frameworks/angular/package.json via @storybook/builder-webpack5@7.0.0-beta.40, code/frameworks/ember/package.json via @storybook/builder-webpack5@7.0.0-beta.40, code/frameworks/html-vite/package.json via @storybook/builder-vite@7.0.0-beta.40, code/frameworks/html-webpack5/package.json via @storybook/builder-webpack5@7.0.0-beta.40, code/frameworks/nextjs/package.json via @storybook/builder-webpack5@7.0.0-beta.40, code/frameworks/preact-vite/package.json via @storybook/builder-vite@7.0.0-beta.40, code/frameworks/preact-webpack5/package.json via @storybook/builder-webpack5@7.0.0-beta.40, code/frameworks/react-vite/package.json via @storybook/builder-vite@7.0.0-beta.40, code/frameworks/react-webpack5/package.json via @storybook/builder-webpack5@7.0.0-beta.40, code/frameworks/server-webpack5/package.json via @storybook/builder-webpack5@7.0.0-beta.40, code/frameworks/svelte-vite/package.json via @storybook/builder-vite@7.0.0-beta.40, code/frameworks/svelte-webpack5/package.json via @storybook/builder-webpack5@7.0.0-beta.40, code/frameworks/sveltekit/package.json via @storybook/builder-vite@7.0.0-beta.40, @storybook/svelte-vite@7.0.0-beta.40, code/frameworks/vue-vite/package.json via @storybook/builder-vite@7.0.0-beta.40, code/frameworks/vue-webpack5/package.json via @storybook/builder-webpack5@7.0.0-beta.40, code/frameworks/vue3-vite/package.json via @storybook/builder-vite@7.0.0-beta.40, code/frameworks/vue3-webpack5/package.json via @storybook/builder-webpack5@7.0.0-beta.40, code/frameworks/web-components-vite/package.json via @storybook/builder-vite@7.0.0-beta.40, code/frameworks/web-components-webpack5/package.json via @storybook/builder-webpack5@7.0.0-beta.40, code/lib/builder-vite/package.json, code/lib/builder-webpack5/package.json
@storybook/preview@7.0.0-beta.40 (added) Function dist/runtime.js code/addons/storyshots-core/package.json via @storybook/angular@7.0.0-beta.40, code/frameworks/angular/package.json via @storybook/builder-webpack5@7.0.0-beta.40, code/frameworks/ember/package.json via @storybook/builder-webpack5@7.0.0-beta.40, code/frameworks/html-vite/package.json via @storybook/builder-vite@7.0.0-beta.40, code/frameworks/html-webpack5/package.json via @storybook/builder-webpack5@7.0.0-beta.40, code/frameworks/nextjs/package.json via @storybook/builder-webpack5@7.0.0-beta.40, code/frameworks/preact-vite/package.json via @storybook/builder-vite@7.0.0-beta.40, code/frameworks/preact-webpack5/package.json via @storybook/builder-webpack5@7.0.0-beta.40, code/frameworks/react-vite/package.json via @storybook/builder-vite@7.0.0-beta.40, code/frameworks/react-webpack5/package.json via @storybook/builder-webpack5@7.0.0-beta.40, code/frameworks/server-webpack5/package.json via @storybook/builder-webpack5@7.0.0-beta.40, code/frameworks/svelte-vite/package.json via @storybook/builder-vite@7.0.0-beta.40, code/frameworks/svelte-webpack5/package.json via @storybook/builder-webpack5@7.0.0-beta.40, code/frameworks/sveltekit/package.json via @storybook/builder-vite@7.0.0-beta.40, @storybook/svelte-vite@7.0.0-beta.40, code/frameworks/vue-vite/package.json via @storybook/builder-vite@7.0.0-beta.40, code/frameworks/vue-webpack5/package.json via @storybook/builder-webpack5@7.0.0-beta.40, code/frameworks/vue3-vite/package.json via @storybook/builder-vite@7.0.0-beta.40, code/frameworks/vue3-webpack5/package.json via @storybook/builder-webpack5@7.0.0-beta.40, code/frameworks/web-components-vite/package.json via @storybook/builder-vite@7.0.0-beta.40, code/frameworks/web-components-webpack5/package.json via @storybook/builder-webpack5@7.0.0-beta.40, code/lib/builder-vite/package.json, code/lib/builder-webpack5/package.json
@storybook/preview@7.0.0-beta.40 (added) Function dist/runtime.js code/addons/storyshots-core/package.json via @storybook/angular@7.0.0-beta.40, code/frameworks/angular/package.json via @storybook/builder-webpack5@7.0.0-beta.40, code/frameworks/ember/package.json via @storybook/builder-webpack5@7.0.0-beta.40, code/frameworks/html-vite/package.json via @storybook/builder-vite@7.0.0-beta.40, code/frameworks/html-webpack5/package.json via @storybook/builder-webpack5@7.0.0-beta.40, code/frameworks/nextjs/package.json via @storybook/builder-webpack5@7.0.0-beta.40, code/frameworks/preact-vite/package.json via @storybook/builder-vite@7.0.0-beta.40, code/frameworks/preact-webpack5/package.json via @storybook/builder-webpack5@7.0.0-beta.40, code/frameworks/react-vite/package.json via @storybook/builder-vite@7.0.0-beta.40, code/frameworks/react-webpack5/package.json via @storybook/builder-webpack5@7.0.0-beta.40, code/frameworks/server-webpack5/package.json via @storybook/builder-webpack5@7.0.0-beta.40, code/frameworks/svelte-vite/package.json via @storybook/builder-vite@7.0.0-beta.40, code/frameworks/svelte-webpack5/package.json via @storybook/builder-webpack5@7.0.0-beta.40, code/frameworks/sveltekit/package.json via @storybook/builder-vite@7.0.0-beta.40, @storybook/svelte-vite@7.0.0-beta.40, code/frameworks/vue-vite/package.json via @storybook/builder-vite@7.0.0-beta.40, code/frameworks/vue-webpack5/package.json via @storybook/builder-webpack5@7.0.0-beta.40, code/frameworks/vue3-vite/package.json via @storybook/builder-vite@7.0.0-beta.40, code/frameworks/vue3-webpack5/package.json via @storybook/builder-webpack5@7.0.0-beta.40, code/frameworks/web-components-vite/package.json via @storybook/builder-vite@7.0.0-beta.40, code/frameworks/web-components-webpack5/package.json via @storybook/builder-webpack5@7.0.0-beta.40, code/lib/builder-vite/package.json, code/lib/builder-webpack5/package.json
@storybook/preview@7.0.0-beta.40 (added) Function dist/runtime.js code/addons/storyshots-core/package.json via @storybook/angular@7.0.0-beta.40, code/frameworks/angular/package.json via @storybook/builder-webpack5@7.0.0-beta.40, code/frameworks/ember/package.json via @storybook/builder-webpack5@7.0.0-beta.40, code/frameworks/html-vite/package.json via @storybook/builder-vite@7.0.0-beta.40, code/frameworks/html-webpack5/package.json via @storybook/builder-webpack5@7.0.0-beta.40, code/frameworks/nextjs/package.json via @storybook/builder-webpack5@7.0.0-beta.40, code/frameworks/preact-vite/package.json via @storybook/builder-vite@7.0.0-beta.40, code/frameworks/preact-webpack5/package.json via @storybook/builder-webpack5@7.0.0-beta.40, code/frameworks/react-vite/package.json via @storybook/builder-vite@7.0.0-beta.40, code/frameworks/react-webpack5/package.json via @storybook/builder-webpack5@7.0.0-beta.40, code/frameworks/server-webpack5/package.json via @storybook/builder-webpack5@7.0.0-beta.40, code/frameworks/svelte-vite/package.json via @storybook/builder-vite@7.0.0-beta.40, code/frameworks/svelte-webpack5/package.json via @storybook/builder-webpack5@7.0.0-beta.40, code/frameworks/sveltekit/package.json via @storybook/builder-vite@7.0.0-beta.40, @storybook/svelte-vite@7.0.0-beta.40, code/frameworks/vue-vite/package.json via @storybook/builder-vite@7.0.0-beta.40, code/frameworks/vue-webpack5/package.json via @storybook/builder-webpack5@7.0.0-beta.40, code/frameworks/vue3-vite/package.json via @storybook/builder-vite@7.0.0-beta.40, code/frameworks/vue3-webpack5/package.json via @storybook/builder-webpack5@7.0.0-beta.40, code/frameworks/web-components-vite/package.json via @storybook/builder-vite@7.0.0-beta.40, code/frameworks/web-components-webpack5/package.json via @storybook/builder-webpack5@7.0.0-beta.40, code/lib/builder-vite/package.json, code/lib/builder-webpack5/package.json
@storybook/preview@7.0.0-beta.40 (added) Function dist/runtime.mjs code/addons/storyshots-core/package.json via @storybook/angular@7.0.0-beta.40, code/frameworks/angular/package.json via @storybook/builder-webpack5@7.0.0-beta.40, code/frameworks/ember/package.json via @storybook/builder-webpack5@7.0.0-beta.40, code/frameworks/html-vite/package.json via @storybook/builder-vite@7.0.0-beta.40, code/frameworks/html-webpack5/package.json via @storybook/builder-webpack5@7.0.0-beta.40, code/frameworks/nextjs/package.json via @storybook/builder-webpack5@7.0.0-beta.40, code/frameworks/preact-vite/package.json via @storybook/builder-vite@7.0.0-beta.40, code/frameworks/preact-webpack5/package.json via @storybook/builder-webpack5@7.0.0-beta.40, code/frameworks/react-vite/package.json via @storybook/builder-vite@7.0.0-beta.40, code/frameworks/react-webpack5/package.json via @storybook/builder-webpack5@7.0.0-beta.40, code/frameworks/server-webpack5/package.json via @storybook/builder-webpack5@7.0.0-beta.40, code/frameworks/svelte-vite/package.json via @storybook/builder-vite@7.0.0-beta.40, code/frameworks/svelte-webpack5/package.json via @storybook/builder-webpack5@7.0.0-beta.40, code/frameworks/sveltekit/package.json via @storybook/builder-vite@7.0.0-beta.40, @storybook/svelte-vite@7.0.0-beta.40, code/frameworks/vue-vite/package.json via @storybook/builder-vite@7.0.0-beta.40, code/frameworks/vue-webpack5/package.json via @storybook/builder-webpack5@7.0.0-beta.40, code/frameworks/vue3-vite/package.json via @storybook/builder-vite@7.0.0-beta.40, code/frameworks/vue3-webpack5/package.json via @storybook/builder-webpack5@7.0.0-beta.40, code/frameworks/web-components-vite/package.json via @storybook/builder-vite@7.0.0-beta.40, code/frameworks/web-components-webpack5/package.json via @storybook/builder-webpack5@7.0.0-beta.40, code/lib/builder-vite/package.json, code/lib/builder-webpack5/package.json
@storybook/preview@7.0.0-beta.40 (added) Function dist/runtime.mjs code/addons/storyshots-core/package.json via @storybook/angular@7.0.0-beta.40, code/frameworks/angular/package.json via @storybook/builder-webpack5@7.0.0-beta.40, code/frameworks/ember/package.json via @storybook/builder-webpack5@7.0.0-beta.40, code/frameworks/html-vite/package.json via @storybook/builder-vite@7.0.0-beta.40, code/frameworks/html-webpack5/package.json via @storybook/builder-webpack5@7.0.0-beta.40, code/frameworks/nextjs/package.json via @storybook/builder-webpack5@7.0.0-beta.40, code/frameworks/preact-vite/package.json via @storybook/builder-vite@7.0.0-beta.40, code/frameworks/preact-webpack5/package.json via @storybook/builder-webpack5@7.0.0-beta.40, [code/frameworks/react-vite/package.json](https://github.com/storybookjs/storybook/pull/20895/files#diff-37

@shilman shilman changed the title Remove the deprecated --no-manager-cache CLI flag for start and build CLI: Remove the deprecated --no-manager-cache flag Feb 2, 2023
@shilman shilman merged commit bc3ec12 into next Feb 2, 2023
@shilman shilman deleted the norbert/fix-20884 branch February 2, 2023 16:39
@WORMSS
Copy link

WORMSS commented Mar 16, 2023

Okay.. so? Should you remove it from documentation? I been spending ages trying to work out what I did to break Storybook to just find the option was purposely removed..
What should I do in it's place?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance User-facing maintenance tasks
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove --no-manager-cache
3 participants