Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CLI: Fix upgrade notification message #22933

Merged
merged 1 commit into from
Jun 6, 2023

Conversation

shilman
Copy link
Member

@shilman shilman commented Jun 6, 2023

N/A

What I did

When the upgrade notification check succeeds, we tell the user to upgrade.

The upgrade message is wrong, however. If the upgrade version is stable, it should benpx storybook@latest upgrade. If the upgrade version is a prerelease, it should be npx storybook@next upgrade --prerelease.

That's because the @next release might contain logic & automigrations that are specific to the next release.

Note that this logic assumes that all prereleases are on the next dist tag, which might not be the case in the future. Also this should be updated when we overhaul the CLI @JReinhold

@shilman shilman added bug cli patch:yes Bugfix & documentation PR that need to be picked to main branch labels Jun 6, 2023
@shilman shilman requested a review from a team as a code owner June 6, 2023 07:31
@shilman shilman self-assigned this Jun 6, 2023
Copy link
Member

@yannbf yannbf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@shilman shilman merged commit 4b520bf into next Jun 6, 2023
@shilman shilman deleted the shilman/fix-cli-upgrade-notification branch June 6, 2023 09:00
@shilman shilman added the patch:done Patch/release PRs already cherry-picked to main/release branch label Jun 6, 2023
shilman added a commit that referenced this pull request Jun 6, 2023
…tification

CLI: Fix upgrade notification message
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug cli patch:done Patch/release PRs already cherry-picked to main/release branch patch:yes Bugfix & documentation PR that need to be picked to main branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants