Storyshots - Replace require_context.js with babel-plugin-require-context-hook #3757
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
igor-dv
requested review from
alexandrebodin,
Hypnosphi,
ndelangen and
thomasbertet
as code owners
igor-dv
changed the title
require_context.js with babel-plugin-require-context-hook
Codecov Report
@@ Coverage Diff @@
## master #3757 +/- ##
========================================
Coverage ? 41%
========================================
Files ? 453
Lines ? 5097
Branches ? 858
========================================
Hits ? 2090
Misses ? 2491
Partials ? 516
Continue to review full report at Codecov.
|
tmeasday
reviewed
Jun 13, 2018
MIGRATION.md
Outdated
| @@ -46,6 +45,7 @@ The `@storybook/react-native` had built-in addons (`addon-actions` and `addon-li | |||
|
|
|||
| 1. `imageSnapshot` test function was extracted from `addon-storyshots` and moved to a new package - `addon-storyshots-puppeteer` that now will be dependant on puppeteer | |||
| 2. `getSnapshotFileName` export was replaced with the `Stories2SnapsConverter` class that now can be overridden for a custom implementation of the snapshot-name generation | |||
| 3. Storybook that was configured with Webpack's `require.context()` feature will need to add a babel plugin to polyfill this functionality. A possible plugin might be [babel-plugin-require-context-hook](https://github.com/smrq/babel-plugin-require-context-hook) | |||
There was a problem hiding this comment.
Is this advice for migrating users? Perhaps something more definite would be good here?
There was a problem hiding this comment.
🤔 I can link to the README explanation about this. WDYT?
| } | ||
| ``` | ||
|
|
||
| Make sure that it is added under the needed environment, |
There was a problem hiding this comment.
"Make sure not to include this babel plugin in the config environment that applies to webpack" -- might be a bit clearer?
Hypnosphi
reviewed
Jun 16, 2018
| @@ -1,43 +0,0 @@ | |||
| import fs from 'fs'; | |||
| import path from 'path'; | |||
| import { getBabelConfig } from '@storybook/core/server'; | |||
There was a problem hiding this comment.
This export can probably be removed from @storybook/core now, as well as @storybook/<framework>/options.js endpoints
igor-dv
requested review from
alterx,
kazupon,
leonrodenburg,
naipath and
shilman
as code owners
Hypnosphi
approved these changes
Jun 16, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: #2894, #3406
What I did
Moved webpack's
require.context()polyfilling out of the storyshots implementation to the babel. It removes the complexity of manual transpylingconfig.js, but just requiring it.