[BUG FIX] Use fixed version of react-dev-utils #3959
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
igor-dv
requested review from
alterx,
danielduan,
Gongreg,
rmevans9,
shilman,
thomasbertet and
tmeasday
as code owners
Codecov Report
@@ Coverage Diff @@
## master #3959 +/- ##
=======================================
Coverage 39.62% 39.62%
=======================================
Files 431 431
Lines 5443 5443
Branches 740 740
=======================================
Hits 2157 2157
Misses 2903 2903
Partials 383 383Continue to review full report at Codecov.
|
igor-dv
changed the title
pksunkara
approved these changes
Aug 5, 2018
|
Yup, a fresh install in vue-kitchen-sink is encountering the same issue. 4.0.0-alpha.15 is completely non-working because of this. I would recommend merging this and publish a new alpha. |
|
CC. @shilman |
|
@shilman please release this asap if you can. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: #3953 #3956
What I did
Somehow, having a caret in
"react-dev-utils": "^6.0.0-next.3e165448"is resolved to an older version ofreact-dev-utils-react-dev-utils@6.0.0-next.b2fd8db8, which is not compatible with webpack 4.It worked in our examples because it locked with the right version in the yarn.lock, but a fresh install might change this.