Add TypeScript CRA example

[mucsi96]

Issue:

What I did

I have created an example incorporating CRA2, TypeScript, TSLint, Jest, Enzyme

Closes #5006
Closes #5011

@igor-dv @ndelangen Please review

[codecov]

Codecov Report

Merging #5120 into next will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             next    #5120   +/-   ##
=======================================
  Coverage   35.23%   35.23%           
=======================================
  Files         596      596           
  Lines        7401     7401           
  Branches     1010     1010           
=======================================
  Hits         2608     2608           
  Misses       4285     4285           
  Partials      508      508

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3698c88...47b31a7. Read the comment docs.

[igor-dv]

We need to setup netlify and CI, other than that LGTM.

[shilman]

This is great. However, it looks like the acceptance test is not set up properly since it's not rendering right in Chromatic. Not sure what's going on because the code looks good to me.

[shilman]

see comment above

[Hypnosphi]

Not sure what's going on

This one should be a symlink not a plain text file:
https://github.com/storybooks/storybook/blob/f9bdd9ab4dfed0561cc3d72e3abb5a35344e0f2b/examples/official-storybook/built-storybooks/cra-ts-kitchen-sink

[shilman]

Hmm Chromatic is still not rendering it properly. Does it work on your dev machine?

[Hypnosphi]

The problem is that right now teamcity doesn't build the new example. You need to add an entry here.
https://github.com/storybooks/storybook/blob/next/.teamcity/OpenSourceProjects_Storybook/buildTypes/StorybookApp.kt#L10
And unfortunatelty you need to do it directly on next branch first because that's the branch that forms the builds graph. You need to set merged flag to false when doing that in next, and then to true in this branch.

[mucsi96]

Can you help with that? I not sure I understand as this is my first contribution to storybook. Probably I don’t have rights for that.

[shilman]

Thanks @Hypnosphi for taking care of the teamcity -- looks great!

[shilman]

@mucsi96 Thanks for your patience on this and your contribution. It looks like the yarn lockfile is dirty. Can you update that and I'll merge?

[mucsi96]

Thx @shilman ! Thx @Hypnosphi for helping out with TeamCity! I updated the lockfile. Unfortunately the CRA TS build is failing with

Failed to resolve artifact dependency <Open-source projects / Storybook / Bootstrap, build #2331 [id 1871311]>: No files matched for patterns "dist.zip" from <Open-source projects / Storybook / Bootstrap, build #2331

Can you help with resolving this?

[shilman]

Looks like it's building now, so I'm merging. Thanks for hanging in there!