-
-
Notifications
You must be signed in to change notification settings - Fork 9.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merge CRA2 webpack plugins #5126
Merge CRA2 webpack plugins #5126
Conversation
Codecov Report
@@ Coverage Diff @@
## next #5126 +/- ##
==========================================
+ Coverage 35.23% 35.55% +0.31%
==========================================
Files 596 596
Lines 7401 7406 +5
Branches 1015 1011 -4
==========================================
+ Hits 2608 2633 +25
+ Misses 4285 4272 -13
+ Partials 508 501 -7
Continue to review full report at Codecov.
|
LGTM what do you say @igor-dv ? |
@ndelangen @Hypnosphi Do you have any idea why the Danger build fails? |
@mucsi96 this #5126 (comment) |
@Hypnosphi Can you remove one of the labels
|
LOL |
@ndelangen @Hypnosphi Can we merge this? |
2 weeks late, but Yey 🔥 |
Issue: #5005
What I did
app/react/src/server/cra-config.js
react-scripts
>2.1.0
@igor-dv Please review