Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge CRA2 webpack plugins #5126

Merged
merged 5 commits into from
Jan 12, 2019

Conversation

mucsi96
Copy link

@mucsi96 mucsi96 commented Dec 31, 2018

Issue: #5005

What I did

  • Increased the test coverage for app/react/src/server/cra-config.js
  • Merge webpack plugins in case of react-scripts > 2.1.0

@igor-dv Please review

@codecov
Copy link

codecov bot commented Dec 31, 2018

Codecov Report

Merging #5126 into next will increase coverage by 0.31%.
The diff coverage is 80%.

Impacted file tree graph

@@            Coverage Diff             @@
##             next    #5126      +/-   ##
==========================================
+ Coverage   35.23%   35.55%   +0.31%     
==========================================
  Files         596      596              
  Lines        7401     7406       +5     
  Branches     1015     1011       -4     
==========================================
+ Hits         2608     2633      +25     
+ Misses       4285     4272      -13     
+ Partials      508      501       -7
Impacted Files Coverage Δ
app/react/src/server/cra-config.js 87.5% <80%> (+40.44%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4df7e18...162f792. Read the comment docs.

@ndelangen ndelangen requested a review from igor-dv January 4, 2019 18:56
@ndelangen ndelangen added configuration babel / webpack typescript cra Prioritize create-react-app compatibility labels Jan 4, 2019
@ndelangen
Copy link
Member

LGTM what do you say @igor-dv ?

@mucsi96
Copy link
Author

mucsi96 commented Jan 8, 2019

@ndelangen @Hypnosphi Do you have any idea why the Danger build fails?

@Hypnosphi
Copy link
Member

@mucsi96 this #5126 (comment)

@Hypnosphi Hypnosphi added maintenance User-facing maintenance tasks bug labels Jan 8, 2019
@mucsi96
Copy link
Author

mucsi96 commented Jan 8, 2019

@Hypnosphi Can you remove one of the labels bug or maintenance. Now it's failing because of both them 🤣

Please choose only one of these labels: ["bug","maintenance"]

@Hypnosphi
Copy link
Member

LOL

@Hypnosphi Hypnosphi removed the maintenance User-facing maintenance tasks label Jan 8, 2019
@mucsi96
Copy link
Author

mucsi96 commented Jan 12, 2019

@ndelangen @Hypnosphi Can we merge this?

@Hypnosphi Hypnosphi merged commit 14fd00b into storybookjs:next Jan 12, 2019
@igor-dv
Copy link
Member

igor-dv commented Jan 14, 2019

2 weeks late, but Yey 🔥

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug configuration babel / webpack cra Prioritize create-react-app compatibility typescript
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants