fix(stories): selectStory correct behavior on call with one parameter
#5983
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
when in `selectStory` passed kind name will redirect on first story in needed kind tests(stories): add test for call `selectStory` with only kind name
Armanio
requested review from
Hypnosphi,
igor-dv,
ndelangen and
tmeasday
as code owners
shilman
added
bug
patch:yes
|
Awesome -- great job! |
shilman
added
the
patch:done
shilman
added a commit
that referenced
this pull request
Mar 11, 2019
fix(stories): `selectStory` correct behavior on call with one parameter
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: #5950
copy from #5953
What I did
Little fix for selectStory function. When in
selectStorypassed kind name will redirect on first story in needed kind.For more information, read that issue.
How to test
Run jest tests
Add links addon to you storybook, call
linkTowith kind name and enjoy redirect to first story in kindYep! I add new jest test (i have doubts on my grammar, i hope anybody correct me)
No
No
Sorry for my bad english, i hope you understand me and feel free for correct me. I will not be upset.