fix(addon-a11y): move redux to dependencies #6286
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shilman
changed the title
shilman
approved these changes
Mar 26, 2019
shilman
added
bug
patch:yes
shilman
removed
the
patch:yes
Codecov Report
@@ Coverage Diff @@
## next #6286 +/- ##
=======================================
Coverage 38.29% 38.29%
=======================================
Files 648 648
Lines 9839 9839
Branches 387 387
=======================================
Hits 3768 3768
Misses 6011 6011
Partials 60 60Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue:
What I did
building storybook was dying over 'redux does not exist'
moving the dependency to
dependenciesshould help.How to test
If your answer is yes to any of these, please make sure to include it in your PR.