Set expanded stores to objects instead of arrays

[dougmacknz]

Issue: #6210

What I did

Fixed the setting of unfilteredExpanded & filteredExpanded to objects instead of arrays (I'm assuming these were meant to be objects).

The bug was happening on treeview.js:153. unfilteredExpanded[key] was being stored as the value. This usually returns a bool if the key exists in the array, but when you run this with an array function name it returns the function itself 😮 😆

How to test

• Change line 5 in examples/cra-kitchen-sink/src/stories/Lifecycle.stories.js to

storiesOf('Map', module).add('logging', () => <LifecycleLogger />);`

cd examples/cra-kitchen-sink
yarn storybook --no-dll

• Open console in your browser.

---

Alternatively I also coded a solution which refactored these stores of expanded items into arrays of sidebar item id's and checked indexOf(), instead of using a key-value relationship. This was before I realised these were probably just meant to be objects. If you'd prefer that solution I can push that up.

[codecov]

Codecov Report

Merging #6290 into next will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             next    #6290   +/-   ##
=======================================
  Coverage   38.29%   38.29%           
=======================================
  Files         648      648           
  Lines        9839     9839           
  Branches      387      387           
=======================================
  Hits         3768     3768           
  Misses       6011     6011           
  Partials       60       60

Impacted Files	Coverage Δ
lib/ui/src/components/sidebar/treeview/treeview.js	57.14% <ø> (ø)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9937954...ff4d3f3. Read the comment docs.

[shilman]

Good one! 🤕