Skip to content
This repository has been archived by the owner on Apr 22, 2024. It is now read-only.

Commit

Permalink
Merge pull request #1 from storyteq/issue-45--compile-error-mac-os-x-…
Browse files Browse the repository at this point in the history
…-node-13-7

Fixed compile error (issue foliojs#45) - upgraded nan to >= 2.14.0 and fixed…
  • Loading branch information
mrspartak committed Jul 14, 2022
2 parents 33b102e + 523d3b3 commit 01732f3
Show file tree
Hide file tree
Showing 3 changed files with 5 additions and 5 deletions.
6 changes: 3 additions & 3 deletions package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
"main": "build/Release/fontmanager",
"types": "index.d.ts",
"dependencies": {
"nan": ">=2.10.0"
"nan": ">=2.14.0"
},
"devDependencies": {
"mocha": "*"
Expand Down
2 changes: 1 addition & 1 deletion src/FontDescriptor.h
Original file line number Diff line number Diff line change
Expand Up @@ -173,7 +173,7 @@ struct FontDescriptor {
MaybeLocal<Value> value = Nan::Get(obj, Nan::New<String>(name).ToLocalChecked());

if (!value.IsEmpty() && value.ToLocalChecked()->IsBoolean()) {
return value.ToLocalChecked()->BooleanValue(Nan::GetCurrentContext()).FromJust();
return value.ToLocalChecked()->BooleanValue((Nan::GetCurrentContext())->GetIsolate());
}

return false;
Expand Down

0 comments on commit 01732f3

Please sign in to comment.