Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

memory: Remove allocator_traits specialization detection #376

Merged
merged 1 commit into from
Jun 27, 2023

Conversation

stotko
Copy link
Owner

@stotko stotko commented Jun 27, 2023

In order to safely skip calling destroy on trivial types, the allocator_traits class is also checked for specializations where the behavior of the construct and destroy functions could potentially be changed in an arbitrary and unpredictable way. As of C++23, such specializations have been forbidden. Thus, remove the check to reduce the maintenance burden.

@stotko stotko added this to the 2.0.0 milestone Jun 27, 2023
@codecov
Copy link

codecov bot commented Jun 27, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: +0.08 🎉

Comparison is base (64f4fe2) 97.32% compared to head (dd26fd6) 97.40%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #376      +/-   ##
==========================================
+ Coverage   97.32%   97.40%   +0.08%     
==========================================
  Files          31       31              
  Lines        2505     2547      +42     
==========================================
+ Hits         2438     2481      +43     
+ Misses         67       66       -1     
Impacted Files Coverage Δ
src/stdgpu/impl/deque_detail.cuh 94.09% <100.00%> (ø)
src/stdgpu/impl/memory_detail.h 99.00% <100.00%> (-0.01%) ⬇️
src/stdgpu/impl/unordered_base_detail.cuh 96.51% <100.00%> (+0.39%) ⬆️
src/stdgpu/impl/vector_detail.cuh 94.59% <100.00%> (ø)

... and 2 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@stotko stotko merged commit d8d3fa3 into master Jun 27, 2023
31 checks passed
@stotko stotko deleted the allocator_traits_specialization branch June 27, 2023 11:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant