Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmake,scripts: Improve thrust detection and upgrade used version in CI #420

Merged
merged 1 commit into from
Jun 19, 2024

Conversation

stotko
Copy link
Owner

@stotko stotko commented Jun 19, 2024

Thrust has been merged together with libcudacxx and CUB into the CUDA C++ Core Libraries (CCCL). Furthermore, thrust 2.X now requires libcudacxx, so our current way of detecting thrust may be incomplete. Extend Findthrust.cmake to account for this new scenario and upgrade the thrust version used in the CI to stay up to date.

Although CCCL 2.4.0 is the newest version, we employ 2.2.0 as there are some outstanding compiler issues with CUDA 12.4+ (which comes with such a more recent version).

@stotko stotko added this to the 2.0.0 milestone Jun 19, 2024
Copy link

codecov bot commented Jun 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.33%. Comparing base (3cd032b) to head (383fa48).

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #420   +/-   ##
=======================================
  Coverage   97.33%   97.33%           
=======================================
  Files          31       31           
  Lines        2512     2512           
=======================================
  Hits         2445     2445           
  Misses         67       67           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@stotko stotko merged commit 5f91561 into master Jun 19, 2024
61 checks passed
@stotko stotko deleted the thrust_upgrade branch June 19, 2024 13:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant