Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmake: Add missing dependency checks in package config #94

Merged
merged 1 commit into from
Feb 8, 2020

Conversation

stotko
Copy link
Owner

@stotko stotko commented Feb 8, 2020

Up to now, dependencies in the package config file are not explicitly stated. Instead, there was the assumption that thrust is located always in the CUDA include directories which are implicitly handled. Although this approach worked until the introduction of the backend system (including an OpenMP backend) and the recent thrust detection cleanup (see #92), it is fundamentally broken now. Properly setup and handle the dependencies in the package config file to fix configuration errors on the user's side.

@stotko stotko added the bug label Feb 8, 2020
@stotko stotko added this to the 1.3.0 milestone Feb 8, 2020
@codecov
Copy link

codecov bot commented Feb 8, 2020

Codecov Report

Merging #94 into master will not change coverage by %.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #94   +/-   ##
=======================================
  Coverage   97.82%   97.82%           
=======================================
  Files          27       27           
  Lines        1611     1611           
=======================================
  Hits         1576     1576           
  Misses         35       35           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a812cd1...991c1a7. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant