Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce a Recipient trait #119

Merged
merged 3 commits into from
Jul 13, 2020
Merged

Introduce a Recipient trait #119

merged 3 commits into from
Jul 13, 2020

Conversation

str4d
Copy link
Owner

@str4d str4d commented Jul 13, 2020

Counterpart to #117, decoupling recipient handling to enable external implementations.

This decouples the recipient implementations from the age library,
enabling external implementations of recipients (leveraging the
flexibility of the age format's single joint).
Precursor to refactoring RecipientKey.
Also removes RecipientKey, as we now have age::x25519::Recipient and
age::ssh::Recipient.
@codecov
Copy link

codecov bot commented Jul 13, 2020

Codecov Report

Merging #119 into master will increase coverage by 0.20%.
The diff coverage is 58.49%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #119      +/-   ##
==========================================
+ Coverage   41.28%   41.48%   +0.20%     
==========================================
  Files          26       26              
  Lines        1933     1926       -7     
==========================================
+ Hits          798      799       +1     
+ Misses       1135     1127       -8     
Impacted Files Coverage Δ
age/src/format.rs 49.39% <ø> (ø)
age/src/identity.rs 51.66% <0.00%> (ø)
age/src/keys.rs 41.17% <ø> (-3.76%) ⬇️
age/src/scrypt.rs 52.83% <ø> (ø)
age/src/ssh/identity.rs 23.47% <ø> (ø)
age/src/x25519.rs 54.44% <54.44%> (ø)
age/src/protocol.rs 71.42% <92.30%> (+1.05%) ⬆️
age/src/ssh/recipient.rs 58.33% <100.00%> (+4.16%) ⬆️
age/src/protocol/decryptor.rs 37.83% <0.00%> (-2.71%) ⬇️
age/src/primitives/armor.rs 48.02% <0.00%> (-2.13%) ⬇️
... and 5 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f80c085...ff974c5. Read the comment docs.

@str4d str4d merged commit 6c36ec8 into master Jul 13, 2020
@str4d str4d deleted the recipient-refactor branch July 13, 2020 10:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant