Introduce an Identity trait #117
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #117 +/- ##
==========================================
- Coverage 41.56% 41.25% -0.32%
==========================================
Files 25 26 +1
Lines 1944 1932 -12
==========================================
- Hits 808 797 -11
+ Misses 1136 1135 -1
Continue to review full report at Codecov.
|
This makes the decryption APIs more flexible in where identities are sourced from.
This decouples the identity implementations from the age library, enabling external implementations of identities (leveraging the flexibility of the age format's single joint). The RecipientStanza enum and its case structs are temporarily made public. They will be replaced by a common struct that all identities parse further when handling them, instead of parsing all stanzas up-front during header parsing.
Parsing of age-native identities is moved to a new IdentityFile struct, and age::cli_common::read_identities now returns Vec<Box<dyn Identity>>, as under the hood it now contains both age::IdentityFile and age::ssh::Identity, which both implement age::Identity.
Identities are now expected to handle any user callbacks themselves. age::ssh::Identity now has a with_callbacks method that returns an implementation of age::Identity.
External crates will need to be able to create FileKeys in order to implement the Identity trait, and will need to be able to to read them in order to implement the future Recipient trait. Also adds some additional zeroizing of temporary variables during FileKey unwrapping.
|
Opened #118 for the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This decouples the identity implementations from the age library, enabling external implementations of identities (leveraging the flexibility of the age format's single joint).
Part of #99.