Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use homebrew formula from homebrew/core #492

Merged
merged 1 commit into from
Jul 18, 2024
Merged

Use homebrew formula from homebrew/core #492

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
47 changes: 0 additions & 47 deletions HomebrewFormula/rage.rb
View file
Open in desktop

This file was deleted.

2 changes: 1 addition & 1 deletion README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ For more plugins, implementations, tools, and integrations, check out the
| Environment | CLI command |
|-------------|-------------|
| Cargo (Rust 1.65+) | `cargo install rage` |
| Homebrew (macOS or Linux) | `brew tap str4d.xyz/rage https://str4d.xyz/rage`<br>`brew install rage` |
| Homebrew (macOS or Linux) | `brew install rage` |
| Alpine Linux (edge) | `apk add rage` |
| Arch Linux | `pacman -S rage-encryption` |
| Debian | [Debian packages](https://github.com/str4d/rage/releases) |
Expand Down
3 changes: 3 additions & 0 deletions tap_migrations.json
View file
Open in desktop
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this file work if it lives in main? When @FiloSottile added the equivalent file alongside merging FiloSottile/age#318, it was into an orphan master branch because that is what Homebrew was fetching from in 2021 (despite I believe FiloSottile/age doing its development in main at the time, as I do here). I don't understand enough about Homebrew taps to know whether the same rationale applies here, and whether this actually needs to be in a master branch.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

From my anecdotal evidence it should work. IIRC I did the same thing with https://github.com/pavelzw/homebrew-pavelzw/blob/main/tap_migrations.json (living on main) and brew managed to read it.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking at the readme in age on master https://github.com/FiloSottile/age/blob/master/README, it seems like age once used master and thus some people's configurations were still using this instead of main. If you used main all along in this project, this should be safe. Otherwise we would probably need to do the same thing...

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay, I'll merge this and we'll see what happens.

Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
{
"rage": "homebrew/core"
}