mongodb_store: encode utf-8 on filling rosmsg #213
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can one of the STRANDS admins verify this patch? Post a comment containing "ok to test" to enable Jenkins builds for this pull request. |
|
Merge build triggered. |
|
Merge build triggered. |
|
@bfalacerda I wonder if this is related to our weird string escape issue! |
|
ok to test |
|
Merge build triggered. |
|
@hawesie Hi, I'm using the patched package for more than a month and have no problem. |
|
Please merge and I'll create a new release this week. |
|
@hawesie Thank you! Merged! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Querying messages including non-ascii unicode string inside fails on filling message data from mongodb BSON document with the error like below:
Since mongodb keeps data only with
utf-8encoding, I added a code to force encode unicode string as 'utf-8' byte string.