mongodb_store: message_store_node.py: deprecate using extra servers #214
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can one of the STRANDS admins verify this patch? Post a comment containing "ok to test" to enable Jenkins builds for this pull request. |
|
Merge build triggered. |
|
ok to test |
|
Merge build triggered. |
…-extra Conflicts: mongodb_store/scripts/message_store_node.py
|
Merge build triggered. |
|
Thanks! |
k-okada
added a commit
to k-okada/mongodb_store
that referenced
this pull request
Apr 10, 2023
strands-project#214 changes default behavior of query when `mongodb_store_extras` is provided. Now we need to set `replicate_on_write` to True to enable this feature.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Discussed in #183
This PR deprecates using extra servers for querying / inserting and set as disabled by default.
Setting an option
~replicate_on_writetrue in order to re-enable this functionality.