Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

move default parameter store #71

Closed
cdondrup opened this issue Aug 8, 2014 · 3 comments
Closed

move default parameter store #71

cdondrup opened this issue Aug 8, 2014 · 3 comments
Assignees

Comments

@cdondrup
Copy link
Member

cdondrup commented Aug 8, 2014

I think if it's going to be in the rosdistro the parameter files should not be stored inside the package but have a configurable path to read the files from. Also the twitter thing should be removed.
Maybe we can have a separate repository for default parameters or put them in scitos_common or similar.

@hawesie hawesie added this to the Prepare for ros distro milestone Aug 8, 2014
@hawesie
Copy link
Member

hawesie commented Aug 8, 2014

It should definitely be removed anyway as this is a public repo so nothing would stop someone accessing that account (if they can work out which one it is).

The default path should probably be an argument to the component.

@cburbridge
Copy link
Member

I'll make it a parameter. The defaults are files that should be shared between users, so are best kept in a repository that is part of the standard install. For strands, the deployment package would be a good place.

The parameters should be stored in a ROS package as this will keep the system independency - then the parameter to the config_manager will be pkg://strands_configs/defaults for example.

@hawesie
Copy link
Member

hawesie commented Aug 10, 2014

Good plan. I'll leave this to you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants