Adding default parameters for ppl perception pipeline #67
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So far no one is really using the config manager and the default parameters apart from the twitter account. Hence, I'm not really sure what the config manager was meant for but I want to use the datacentre for the myriade of config parameters the ppl perception currently has. All of these haven't been changed since it was rosyfied last year so they can be considered default I presume.
Tested on Linda and thanks to @cburbridge it works fine.
Maybe @cburbridge and @kunzel can give this PR a try to test if the datacentre does what it's supposed to and to see if the ppl perception works.