Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make public and release #6

Open
hawesie opened this issue May 10, 2016 · 3 comments
Open

Make public and release #6

hawesie opened this issue May 10, 2016 · 3 comments
Assignees

Comments

@hawesie
Copy link
Member

hawesie commented May 10, 2016

Hey @Pandoro please can you make this public and release it? Some of our other packages now depend on it, so it would be useful if we can now include this in the normal STRANDS release procedures.

@hawesie
Copy link
Member Author

hawesie commented May 10, 2016

An alternative approach might be to separate the service definitions out to a releasable package and keep the implementation private.

@Pandoro
Copy link
Contributor

Pandoro commented May 10, 2016

If people are actually using this, I'm fine with releasing it. I just a have some issues about the licensing since I'm not really an expert on this and I just copy pasted the code form three projects who are all released with different licenses and partially contain even different external libraries. If anyone could give me some pointers here on how to handle this the best I'd be happy to release it. I'd be fine with an MIT license, I just guess I can't do that if I use other stuff not using the same license?

Furthermore the RF model is very specific for the STRANDS case and will completely fail if anyone just uses it with something else. I'm fine with releasing it as is, I'm just not really sure how to deal with the download from the random forest model file. Should this be handled during the installing of the package, e.g. in a setup file that downloads it?

@hawesie
Copy link
Member Author

hawesie commented Jun 6, 2016

It's public.

@hawesie hawesie closed this as completed Jun 6, 2016
@hawesie hawesie reopened this Jun 6, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants