-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[quasimodo] Integrate mongodb world_state observations and enable querying individual databases #111
Merged
RaresAmbrus
merged 79 commits into
strands-project:hydro-devel
from
nilsbore:integrate_object_search
May 4, 2017
Merged
[quasimodo] Integrate mongodb world_state observations and enable querying individual databases #111
RaresAmbrus
merged 79 commits into
strands-project:hydro-devel
from
nilsbore:integrate_object_search
May 4, 2017
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…the retrieval package to take this into account
…es from world_state database
…vice is avaialable even if the metaroom is still processing and added respawn to the processing nodes
…e analysis easier
So this finally(!) passes. @RaresAmbrus OK to merge? |
Ok, @RaresAmbrus , I think this is fine to merge now, I included some licensing text in the stopwatch project. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR integrates quasimodo with the world_state representation of the object search framework. It enables us to use the mongodb observations intermixed with the meta room ones. Further, it uses this representation to enable @jekekrantz to query for top matches among his built models to speed up matching of models in his database. This will be used to associate observations from @jayyoung 's object search system.
If @jekekrantz could test this before merging, that would be good. Note that when searching for objects in your models, you need to pass the flag
query_msg.query_kind = quasimodo_msgs::retrieval_query::MONGODB_QUERY
.To add a model to the database, you need to have
mongodb
running, as well asrosrun quasimodo_object_search insert_object_server.py
. You then need to pass a service according to this definition, inquasimodo_msgs/insert_model.srv
:This is currently announced at
/insert_model_service
. ForINSERT
, you only need to pass themodel
argument. You then get anobject_id
back that you need to keep track of. When you want to remove this model again, passREMOVE
together with theobject_id
.@jayyoung If you have
soma_manager/soma2_local.launch
running together withquasimodo_object_search/create_object_search_observation.py
, this code will automatically add new entries added to theworld_state
database. For querying these observations, the procedure is the same as above. ATM, you need asemanticMap
database to train the underlying representation to be able to use this.