Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Onomy enhancements #81

Merged
merged 11 commits into from
Feb 2, 2023
Merged

Onomy enhancements #81

merged 11 commits into from
Feb 2, 2023

Conversation

DavidNix
Copy link
Contributor

@DavidNix DavidNix commented Jan 31, 2023 •
edited
Loading

Onomy

@DavidNix DavidNix changed the title feat: Rust build flexibility, Onomy enhancements Refactor Rust build flexibility + Onomy enhancements Jan 31, 2023
@DavidNix DavidNix changed the title Refactor Rust build flexibility + Onomy enhancements Refactor Rust build-target + Onomy enhancements Jan 31, 2023
@agouin
Copy link
Member

agouin commented Jan 31, 2023 •
edited
Loading

--target is a flag specific to cargo. The required flag also means that multi-line build-target will not work for rust. I posted my reasoning on not touching rust for now here.

If we want to handle this now, we should do something like export a CARGO_TARGET env var in the Dockerfiles which can be used by the specific chain build-target cargo commands

@DavidNix DavidNix mentioned this pull request Jan 31, 2023
Closed
@DavidNix DavidNix changed the title Refactor Rust build-target + Onomy enhancements Onomy enhancements Feb 1, 2023
DavidNix
DavidNix commented Feb 1, 2023
View reviewed changes
chains.yaml
Comment on lines +548 to 551
# TODO: Heighliner will not produce working builds until https://github.com/onomyprotocol/onomy/pull/129 merged.
# If PR not merged for your git-ref, then update and push to our fork, https://github.com/strangelove-ventures/onomy, with Onomy upstream.
# And manually run heighliner command with `-o strangelove-ventures --git-ref main --tag <semver>`.
build-target: make install
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@agouin Decided to take this approach vs. a long build target.

As of this writing, onomyprotocol/onomy#129 has no activity from the Onomy team. I've reached out to them in our dedicated slack channel.

@DavidNix DavidNix marked this pull request as ready for review February 1, 2023 18:32
agouin
agouin reviewed Feb 2, 2023
View reviewed changes
chains.yaml Outdated
- name: onomy-gbt
github-organization: onomyprotocol
github-repo: arc
dockerfile: rust
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will work but rust is now deprecated. cargo replaces it.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, I missed that deprecation. I'll make a quick update.

@DavidNix DavidNix merged commit 43746b6 into main Feb 2, 2023
@DavidNix DavidNix deleted the nix/feat/onomy-improvements branch February 2, 2023 19:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danbryan danbryan danbryan approved these changes

@agouin agouin agouin approved these changes

@boojamya boojamya Awaiting requested review from boojamya

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Onomy artifact does not work
3 participants
@DavidNix @agouin @danbryan