Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix go version check for local builds #86

Merged
merged 2 commits into from
Feb 3, 2023
Merged

Fix go version check for local builds #86

merged 2 commits into from
Feb 3, 2023

Conversation

agouin
Copy link
Member

@agouin agouin commented Feb 2, 2023

Go version needs to check a local file, not a git cloned file, when --local is set.

DavidNix
DavidNix approved these changes Feb 2, 2023
View reviewed changes
Copy link
Contributor

@DavidNix DavidNix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few nits, but looks good!

builder/builder.go Outdated Show resolved Hide resolved
builder/builder.go Show resolved Hide resolved
builder/builder.go Outdated Show resolved Hide resolved
@agouin agouin mentioned this pull request Feb 3, 2023
Merged
@agouin agouin force-pushed the andrew/fix_go_version_check_local branch from 66e2e55 to 58e7060 Compare February 3, 2023 20:28
@agouin agouin merged commit 0d8cf46 into main Feb 3, 2023
@agouin agouin deleted the andrew/fix_go_version_check_local branch February 3, 2023 20:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DavidNix DavidNix DavidNix approved these changes

@boojamya boojamya Awaiting requested review from boojamya

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@agouin @DavidNix