Badge: Update colors and height according to the UI kit #770
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
Size Change: +309 B (0%) Total Size: 513 kB
ℹ️ View Unchanged
|
ronronscelestes
approved these changes
Nov 14, 2022
joshuaellis
requested changes
Nov 14, 2022
joshuaellis
approved these changes
Nov 14, 2022
There was a problem hiding this comment.
We have made a compromise on this component a few months ago but on the other way around. Making sure that the Media Library badge (the one that you could see on the cards) could have the same padding as the badge that we see in the subnav. I think the subnav badge would be too narrowed which I'm not a fan of. I wouldn't not go for this change :)
|
@maevalienard What do you think about creating two variants for this component then? |
|
@gu-stav Usually, I'm not fan to introduce too many possibilities but I don't see the issue here. That would work to me :) |
|
@maevalienard Cool. I think in this case it could make sense. Would you like to go ahead and create both variants (S and M) in the UI Kit first? |
|
@gu-stav Is it just a change of border-radius or also a change of padding? If also padding could you please let me know about the two variants to have? |
|
@maevalienard Up to you. I imagine this might work: S: height=16px, border-radius=2px Currently, the badge is height=24px and border-radius=4px. |
|
Sounds good to me. I'm changing the UI Kit accordingly right now |
|
@maevalienard I think it also might be useful to define: S: padding-left/ padding-right: 1 Otherwise it looks a bit cramped. What do you think? |
|
Updated ✅ |
|
@maevalienard Just to avoid any misunderstanding: I'm looking at https://www.figma.com/file/zUx2bwEZId1RHZBM6zT14e/Strapi---Website-UI-Kit-%F0%9F%A7%A9?node-id=1431%3A31181&t=1y1oYB7XXIppy3b6-1 and can only see one variant which has once a height of 20px and once of 19px. In both cases the Typography doesn't match the
|
joshuaellis
added
the
flag: don't merge
|
This is the website (ie strapi.io) UI kit, it has nothing to do with the CMS design system :) |
|
Oh thanks. My bad :) The DS UI Kit looks much better:
:) However: the height of the medium badge is |
|
I'll take that compliment 😂 Indeed, I might have mistaken somewhere. I'll fix that right away, thanks :) |
gu-stav
force-pushed
the
fix/badge-height-colors
branch
from
d7067d8
to
b013ae0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does it do?
Badgeto match the UI Kitborder-radiusfrom4pxto2pxWhy is it needed?
Match the UI Kit
Related issue(s)/PR(s)