Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: setup error on windows #997

Closed

Conversation

Minecraftschurli
Copy link
Contributor

What does it do?

Fixed the error when running yarn setup on windows (#996)

Why is it needed?

Setting up the project on windows was broken

How to test it?

Run the setup script on windows (and other os)

Related issue(s)/PR(s)

fixes #996

@vercel
Copy link

vercel bot commented May 5, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
design-system ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 5, 2023 0:43am
design-system-website ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 5, 2023 0:43am

Copy link
Member

@joshuaellis joshuaellis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure about changing the external function so much – could we not just change:

external: (id) => !id.startsWith('.') && !id.startsWith('/'), 

to

external: (id) => !id.startsWith('.') && !id.startsWith(path.sep),

would that work instead? 🤔

@joshuaellis
Copy link
Member

closing due to inactivity.

@joshuaellis joshuaellis closed this Oct 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr: fix This PR is fixing a bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[bug]: Error after cloning repo
2 participants