Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add http.serverOptions config #1903

Merged
merged 2 commits into from
Nov 8, 2023
Merged

Add http.serverOptions config #1903

merged 2 commits into from
Nov 8, 2023

Conversation

innerdvations
Copy link
Collaborator

@innerdvations innerdvations commented Oct 30, 2023

To be merged after this PR: strapi/strapi#18591

It's not merged and we don't have a milestone that can be used yet, I'll add it both here and to the code PR once the milestone exists.

@innerdvations innerdvations added the pr: new content PRs for new product features or new documentation sections label Oct 30, 2023
@vercel
Copy link

vercel bot commented Oct 30, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
documentation ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 30, 2023 2:40pm

@innerdvations innerdvations marked this pull request as ready for review October 30, 2023 14:34
@pwizla pwizla self-assigned this Nov 6, 2023
@pwizla pwizla added source: Dev Docs PRs/issues targeting the Developer Docs pr: chore and removed pr: new content PRs for new product features or new documentation sections labels Nov 6, 2023
@SimonStorlSchulke
Copy link
Contributor

SimonStorlSchulke commented Nov 6, 2023

Hi - love these changes. In our team we however discovered that the requestTimeout option also applies to file uploads. So if you try to upload a large file, with the default settings, it times out after 330 seconds if you don't set this setting to something larger. So I think it's important to also mention this in the documentation of the upload plugin. I created a pr for the documentation here #1907 - but with these changes, the way to do it would of course be different.

@innerdvations
Copy link
Collaborator Author

@SimonStorlSchulke Great catch, thanks! I didn't realize upload was already looking for a different option. I will try to reconcile them before merging this so we don't end up with options in two places.

@innerdvations
Copy link
Collaborator Author

innerdvations commented Nov 6, 2023

@pwizla The code PR has been merged and will go out in the next release, and this docs PR should go out then as-is.

#1907 could work as a nice addition, but it should specifically reference this one as the way to do it in a config file, and the method mentioned in that PR should be considered an alternate method of doing it in cases where it needs to change programmatically -- for example, if they want to temporarily disable and re-enable it like we're doing for data-transfer

@pwizla
Copy link
Collaborator

pwizla commented Nov 8, 2023

Hi @innerdvations. I can see the 4.15.3 milestone has been added to the strapi/strapi PR. It would be released next week, then, right?

@innerdvations
Copy link
Collaborator Author

I've updated the milestone to 4.15.2, I believe it should be released today actually, thanks for the catch :)

@innerdvations innerdvations added this to the 4.15.2 milestone Nov 8, 2023
@pwizla pwizla merged commit b515cb8 into main Nov 8, 2023
3 checks passed
@pwizla pwizla deleted the feat/http-serveroptions-config branch November 8, 2023 16:48
@pwizla pwizla added the temp: port to v5 Temporary label for PRs that need to be ported to v5 docs label Nov 13, 2023
@pwizla pwizla removed the temp: port to v5 Temporary label for PRs that need to be ported to v5 docs label Dec 20, 2023
pwizla added a commit that referenced this pull request Dec 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr: chore source: Dev Docs PRs/issues targeting the Developer Docs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants