feat: allow passing http serverOptions from config #18591
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
innerdvations
requested review from
alexandrebodin,
derrickmehaffy,
christiancp100 and
Marc-Roig
innerdvations
added
source: core:strapi
I do too, I think it would provide a lot of solutions to edge cases, and if we like this, I will probably do the same for Koa, Apollo, and any other external modules we use. We already do it with Knex. Ultimately however this is a philosophical question that I'll need to wait for a consensus on before we can merge. |
Marc-Roig
previously approved these changes
Oct 27, 2023
innerdvations
dismissed stale reviews from Marc-Roig and derrickmehaffy
via
22fc154
pwizla
approved these changes
Nov 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does it do?
Allows user to set http server configuration options
Why is it needed?
The specific issue is that Strapi can no longer accept any file uploads that take longer than the default Node 18+ http server requestTimeout, which is 5 minutes.
This allows users to configure that setting to be whatever value they wish.
In addition to that, users will now be able to configure any option available in http.ServerOptions
How to test it?
Try setting some values in config/server.ts http.serverOptions and see that they are passed through to the http.createServer
Related issue(s)/PR(s)
Fixes #18543
Documentation PR