Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new proxy configuration feature #2124

Merged
merged 2 commits into from
Jun 13, 2024
Merged

Add new proxy configuration feature #2124

merged 2 commits into from
Jun 13, 2024

Conversation

innerdvations
Copy link
Collaborator

@innerdvations innerdvations commented Jun 13, 2024

What does it do?

Adds the new proxy configuration settings

(sorry for the formatting changes again, with the table it was difficult to get git to recognize it correctly without updating the whole table)

Why is it needed?

The configuration settings have been changed (breaking change for server.proxy and server.globalProxy) and new settings have been added

Related issue(s)/PR(s)

strapi/strapi#20416

@innerdvations innerdvations added the flag: 💥 Breaking change This PR contains breaking changes and should not be merged label Jun 13, 2024
Copy link

vercel bot commented Jun 13, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
documentation ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 13, 2024 8:28am

@pwizla
Copy link
Collaborator

pwizla commented Jun 13, 2024

Thank you, Ben! The PR looks good to me, I'll merge it right now and handle documenting the breaking change entry that you added to the Notion database 👌

@pwizla pwizla self-assigned this Jun 13, 2024
@pwizla pwizla added the v5 Documentation PR that targets Strapi v5 label Jun 13, 2024
@pwizla pwizla added this to the 5.0.0 (stable) milestone Jun 13, 2024
@pwizla pwizla merged commit 7413fec into next Jun 13, 2024
3 checks passed
@pwizla pwizla deleted the feat/proxy-configuration branch June 13, 2024 09:59
@innerdvations
Copy link
Collaborator Author

Ok! The parent PR hasn't been merged yet, hopefully it happens before the next beta release 😆

@pwizla
Copy link
Collaborator

pwizla commented Jun 13, 2024

Oops I'm sorry, I can definitely roll back if needed.
Sometimes I go really too fast and should think through a bit more 😅 🤦‍♂️

@pwizla pwizla modified the milestones: 5.0.0 (stable), 5.0.0-rc.0 Jun 26, 2024
@pwizla pwizla modified the milestones: 5.0.0-rc.0, 5.0.0 (stable) Aug 13, 2024
@pwizla pwizla added pr: new content PRs for new product features or new documentation sections source: Dev Docs PRs/issues targeting the Developer Docs labels Aug 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
flag: 💥 Breaking change This PR contains breaking changes and should not be merged pr: new content PRs for new product features or new documentation sections source: Dev Docs PRs/issues targeting the Developer Docs v5 Documentation PR that targets Strapi v5
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants