chore: mark feedback

strapi · Apr 4, 2024 · 2db7376 · 2db7376
1 parent 9b7f779
commit 2db7376
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 4 deletions.
diff --git a/packages/core/content-manager/server/src/history/services/history.ts b/packages/core/content-manager/server/src/history/services/history.ts
@@ -1,4 +1,4 @@
-import type { Core, Modules, UID, Data, Struct } from '@strapi/types';
+import type { Core, Modules, UID, Data, Schema } from '@strapi/types';
 import { contentTypes } from '@strapi/utils';
 import { omit, pick } from 'lodash/fp';
 
@@ -280,7 +280,7 @@ const createHistoryService = ({ strapi }: { strapi: Core.Strapi }) => {
        */
       const buildRelationReponse = async (
         values: EntryToPopulate[],
-        attributeSchema: Struct.SchemaAttributes[keyof Struct.SchemaAttributes]
+        attributeSchema: Schema.Attribute.AnyAttribute
       ): Promise<{ results: any[]; meta: { missingCount: number } }> => {
         return (
           values
@@ -311,6 +311,7 @@ const createHistoryService = ({ strapi }: { strapi: Core.Strapi }) => {
                       .documents(attributeSchema.target)
                       .findOne(entry.documentId, { locale: entry.locale || undefined });
                   }
+                  // For media assets, only the id is available, double check that we have it
                 } else if ('id' in entry) {
                   relatedEntry = await strapi.db
                     .query('plugin::upload.file')

diff --git a/packages/core/content-manager/shared/contracts/history-versions.ts b/packages/core/content-manager/shared/contracts/history-versions.ts
@@ -12,8 +12,8 @@ export interface CreateHistoryVersion {
   locale: string | null;
   status: 'draft' | 'published' | 'modified' | null;
   data: Record<string, unknown>;
-  schema: Schema.Attributes;
-  componentsSchemas: Record<`${string}.${string}`, Schema.Attributes>;
+  schema: Struct.SchemaAttributes;
+  componentsSchemas: Record<`${string}.${string}`, Struct.SchemaAttributes>;
 }
 
 interface Locale {