Skip to content

Commit

Permalink
Merge pull request #14839 from strapi/fix/relations-knex-raw
Browse files Browse the repository at this point in the history
Fix: knex withSchema.raw error
  • Loading branch information
jhoward1994 committed Nov 16, 2022
2 parents bcc1eed + 0429557 commit 49c4ba2
Showing 1 changed file with 9 additions and 11 deletions.
20 changes: 9 additions & 11 deletions packages/core/database/lib/entity-manager/regular-relations.js
Original file line number Diff line number Diff line change
Expand Up @@ -226,8 +226,7 @@ const cleanOrderColumns = async ({ id, attribute, db, inverseRelIds, transaction
// https://github.com/knex/knex/issues/2504
switch (strapi.db.dialect.client) {
case 'mysql':
await db
.getConnection()
await db.connection
.raw(
`UPDATE
?? as a,
Expand All @@ -243,17 +242,16 @@ const cleanOrderColumns = async ({ id, attribute, db, inverseRelIds, transaction
.transacting(trx);
break;
default:
await db
.getConnection()
await db.connection
.raw(
`UPDATE ?? as a
SET ${update.join(', ')}
FROM (
SELECT ${select.join(', ')}
FROM ??
WHERE ${where.join(' OR ')}
) AS b
WHERE b.id = a.id`,
SET ${update.join(', ')}
FROM (
SELECT ${select.join(', ')}
FROM ??
WHERE ${where.join(' OR ')}
) AS b
WHERE b.id = a.id`,
[joinTable.name, ...updateBinding, ...selectBinding, joinTable.name, ...whereBinding]
)
.transacting(trx);
Expand Down

0 comments on commit 49c4ba2

Please sign in to comment.