Skip to content

Commit

Permalink
fix: infinite loop
Browse files Browse the repository at this point in the history
  • Loading branch information
joshuaellis committed Mar 13, 2024
1 parent 834e9de commit 78178ea
Showing 1 changed file with 11 additions and 2 deletions.
Expand Up @@ -24,6 +24,7 @@ import {
useStrapiApp,
} from '@strapi/helper-plugin';
import { ArrowLeft, Plus } from '@strapi/icons';
import isEqual from 'lodash/isEqual';
import { stringify } from 'qs';
import { useIntl } from 'react-intl';
import { useNavigate, Link as ReactRouterLink } from 'react-router-dom';
Expand All @@ -44,6 +45,7 @@ import {
convertListLayoutToFieldLayouts,
useDocumentLayout,
} from '../../hooks/useDocumentLayout';
import { usePrev } from '../../hooks/usePrev';
import { useSyncRbac } from '../../hooks/useSyncRbac';
import { useDeleteDocumentMutation, useGetAllDocumentsQuery } from '../../services/documents';
import { buildValidParams } from '../../utils/api';
Expand Down Expand Up @@ -84,9 +86,16 @@ const ListViewPage = () => {

const [displayedHeaders, setDisplayedHeaders] = React.useState<ListFieldLayout[]>([]);

const listLayout = usePrev(list.layout);
React.useEffect(() => {
setDisplayedHeaders(list.layout);
}, [list.layout]);
/**
* ONLY update the displayedHeaders if the document
* layout has actually changed in value.
*/
if (!isEqual(listLayout, list.layout)) {
setDisplayedHeaders(list.layout);
}
}, [list.layout, listLayout]);

const handleSetHeaders = (headers: string[]) => {
setDisplayedHeaders(
Expand Down

0 comments on commit 78178ea

Please sign in to comment.