Register logger middleware before errors middleware

In the examples and project templates the "errors" middleware which turn thrown errors into HTTP responses is registered before the "logger" middleware. This causes any errors thrown in controllers to pierce through the logger middleware resulting in these requests not being logged. Eg. when a controller throws a ValidationError the resulting HTTP 400 request is not logged at all. Change the order of middleware registration so that the logger is 'above' the errors middleware and has a chance to log *all* requests.
strapi · Nov 8, 2023 · 92bb176 · 92bb176
1 parent 22ffc8b
commit 92bb176
Show file tree

Hide file tree

Showing 5 changed files with 5 additions and 5 deletions.
diff --git a/examples/getstarted/config/middlewares.js b/examples/getstarted/config/middlewares.js
@@ -3,11 +3,11 @@
 const responseHandlers = require('./src/response-handlers');
 
 module.exports = [
+  'strapi::logger',
   'strapi::errors',
   'strapi::security',
   'strapi::cors',
   'strapi::poweredBy',
-  'strapi::logger',
   'strapi::query',
   'strapi::body',
   'strapi::session',

diff --git a/examples/kitchensink-ts/config/middlewares.ts b/examples/kitchensink-ts/config/middlewares.ts
@@ -1,9 +1,9 @@
 export default [
+  'strapi::logger',
   'strapi::errors',
   'strapi::security',
   'strapi::cors',
   'strapi::poweredBy',
-  'strapi::logger',
   'strapi::query',
   'strapi::body',
   'strapi::session',

diff --git a/packages/core/strapi/src/services/server/register-middlewares.ts b/packages/core/strapi/src/services/server/register-middlewares.ts
@@ -5,12 +5,12 @@ import { resolveMiddlewares } from './middleware';
 type MiddlewareConfig = (string | { name?: string; resolve?: string; config?: unknown })[];
 
 const defaultConfig = [
+  'strapi::logger',
   'strapi::errors',
   'strapi::security',
   'strapi::cors',
   'strapi::poweredBy',
   'strapi::session',
-  'strapi::logger',
   'strapi::query',
   'strapi::body',
   'strapi::favicon',

diff --git a/packages/generators/app/src/resources/files/js/config/middlewares.js b/packages/generators/app/src/resources/files/js/config/middlewares.js
@@ -1,9 +1,9 @@
 module.exports = [
+  'strapi::logger',
   'strapi::errors',
   'strapi::security',
   'strapi::cors',
   'strapi::poweredBy',
-  'strapi::logger',
   'strapi::query',
   'strapi::body',
   'strapi::session',

diff --git a/packages/generators/app/src/resources/files/ts/config/middlewares.ts b/packages/generators/app/src/resources/files/ts/config/middlewares.ts
@@ -1,9 +1,9 @@
 export default [
+  'strapi::logger',
   'strapi::errors',
   'strapi::security',
   'strapi::cors',
   'strapi::poweredBy',
-  'strapi::logger',
   'strapi::query',
   'strapi::body',
   'strapi::session',