Merge pull request #15197 from strapi/fix/deadlock-mysql-inverse-order

Avoid deadlocks for mysql and mariadb when creating a Nth locale
strapi · Dec 16, 2022 · a8064a0 · a8064a0
2 parents bd6c0fc + 0413f27
commit a8064a0
Showing 1 changed file with 2 additions and 4 deletions.
diff --git a/packages/core/database/lib/entity-manager/regular-relations.js b/packages/core/database/lib/entity-manager/regular-relations.js
@@ -328,7 +328,7 @@ const cleanOrderColumnsForInnoDB = async ({
       await db.connection
         .raw(
           `
-          CREATE TEMPORARY TABLE ??
+          CREATE TABLE ??
             SELECT
               id,
               (
@@ -361,9 +361,7 @@ const cleanOrderColumnsForInnoDB = async ({
         )
         .transacting(trx);
     } finally {
-      await db.connection
-        .raw(`DROP TEMPORARY TABLE IF EXISTS ??`, [tempInvOrderTableName])
-        .transacting(trx);
+      await db.connection.raw(`DROP TABLE IF EXISTS ??`, [tempInvOrderTableName]).transacting(trx);
     }
   }
 };