chore(content-releases): fix HeaderLayout wrong height because of sub…

…title empty on loading
strapi · Jan 29, 2024 · f114e59 · f114e59
1 parent f08b19a
commit f114e59
Show file tree

Hide file tree

Showing 2 changed files with 14 additions and 9 deletions.
diff --git a/packages/core/content-releases/admin/src/pages/ReleasesPage.tsx b/packages/core/content-releases/admin/src/pages/ReleasesPage.tsx
@@ -74,15 +74,19 @@ export const ReleasesLayout = ({
           defaultMessage: 'Releases',
         })}
         subtitle={
-          !isLoading &&
-          formatMessage(
-            {
-              id: 'content-releases.pages.Releases.header-subtitle',
-              defaultMessage:
-                '{number, plural, =0 {No releases} one {# release} other {# releases}}',
-            },
-            { number: totalReleases }
-          )
+          !isLoading
+            ? formatMessage(
+                {
+                  id: 'content-releases.pages.Releases.header-subtitle',
+                  defaultMessage:
+                    '{number, plural, =0 {No releases} one {# release} other {# releases}}',
+                },
+                { number: totalReleases }
+              )
+            : formatMessage({
+                id: 'content-releases.pages.Releases.header-subtitle-default',
+                defaultMessage: 'No releases',
+              })
         }
         primaryAction={
           <CheckPermissions permissions={PERMISSIONS.create}>

diff --git a/packages/core/content-releases/admin/src/translations/en.json b/packages/core/content-releases/admin/src/translations/en.json
@@ -17,6 +17,7 @@
   "plugin.name": "Releases",
   "pages.Releases.title": "Releases",
   "pages.Releases.header-subtitle": "{number, plural, =0 {No releases} one {# release} other {# releases}}",
+  "pages.Releases.header-subtitle-default": "No releases",
   "pages.Releases.max-limit-reached.title": "You have reached the {number} pending {number, plural, one {release} other {releases}} limit.",
   "pages.Releases.max-limit-reached.message": "Upgrade to manage an unlimited number of releases.",
   "pages.Releases.max-limit-reached.action": "Explore plans",