Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Drag icon in repeatable component not visible in dark mode #15141

Closed
BhuvaneshPatil opened this issue Dec 9, 2022 · 3 comments · Fixed by #15119
Closed

Drag icon in repeatable component not visible in dark mode #15141

BhuvaneshPatil opened this issue Dec 9, 2022 · 3 comments · Fixed by #15119
Assignees
@joshuaellis
Labels
good first issue Good for newcomers issue: bug Issue reporting a bug severity: medium If it breaks the basic use of the product but can be worked around source: core:content-manager Source is core/content-manager package status: confirmed Confirmed by a Strapi Team member or multiple community members

Comments

@BhuvaneshPatil
Copy link

BhuvaneshPatil commented Dec 9, 2022 •
edited

Bug report

Required System information

  • Node.js version: 16.18.0
  • NPM version: 8.19.2
  • Strapi version: 4.5.3
  • Database: Not Relevant
  • Operating system: Windows 11

Describe the bug

In the dark mode, the Drag icon is not visible, adding repeatable components.

Steps to reproduce the behavior

  1. Create a content-type with a repeatable component
  2. Add items and observe.

Expected behavior

Icon's color should change according to the mode. For Example - In light mode it has dark color.
That same color is being used here.

Screenshots

On hover -

Drag Icon - On Hover

Without hover -

Drag Icon - Without hover

@BhuvaneshPatil
Copy link
Author

BhuvaneshPatil commented Dec 9, 2022 •
edited

If this is valid issue/bug, I want to work on it and solve it.

This was referenced Dec 9, 2022
Closed
Closed
Closed
@derrickmehaffy
Copy link
Member

Confirmed in v4.5.4:
image

@BhuvaneshPatil please feel free to submit a PR and just add the fixes #15142 to the PR description :)

@derrickmehaffy derrickmehaffy added issue: bug Issue reporting a bug severity: medium If it breaks the basic use of the product but can be worked around good first issue Good for newcomers status: confirmed Confirmed by a Strapi Team member or multiple community members source: core:content-manager Source is core/content-manager package labels Dec 27, 2022
@joshuaellis joshuaellis mentioned this issue Jan 10, 2023
Merged
@joshuaellis
Copy link
Member

This will be fixed with 4.6

@joshuaellis joshuaellis self-assigned this Jan 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@joshuaellis joshuaellis

Labels
good first issue Good for newcomers issue: bug Issue reporting a bug severity: medium If it breaks the basic use of the product but can be worked around source: core:content-manager Source is core/content-manager package status: confirmed Confirmed by a Strapi Team member or multiple community members
Projects
Content Platform Squad
Status: Fixed/Shipped
Support team
Archived in project
Milestone
No milestone
3 participants
@derrickmehaffy @BhuvaneshPatil @joshuaellis