Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Relations & Dynamic Zones reordering #15119

Merged
merged 234 commits into from Jan 17, 2023
Merged

Conversation

joshuaellis
Copy link
Member

@joshuaellis joshuaellis commented Dec 8, 2022

What does it do?

  • Adds relations re-ordering (BE & FE)
  • Adds dynamic zones re-ordering (drag and drop FE only)

Related Issues

Marc-Roig and others added 30 commits October 24, 2022 09:22
…ionInput/components/RelationItem.js

Co-authored-by: Gustav Hansen <gustav.hansen@strapi.io>
Copy link
Contributor

@gu-stav gu-stav left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well done everyone! 👏🏼

@joshuaellis joshuaellis removed the flag: don't merge This PR should not be merged at the moment label Jan 17, 2023
@joshuaellis joshuaellis merged commit ea3f7fa into main Jan 17, 2023
@joshuaellis joshuaellis deleted the feature/relations-reordering branch January 17, 2023 11:09
@Boegie19
Copy link
Collaborator

Just a quick question is this able to be disabled since lets say I have 99999 relationships to 1 entity what would be the performance hit and would I be able disabled so you don't get the hit at all if you don't need reordering of relationships

@joshuaellis
Copy link
Member Author

Just a quick question is this able to be disabled since lets say I have 99999 relationships to 1 entity what would be the performance hit and would I be able disabled so you don't get the hit at all if you don't need reordering of relationships

IMO this is too granular a step for permissions. This then becomes permissions on actions per field type which raises a lot more questions re. dynamic zones should you be able to not reorder them etc?

@Boegie19
Copy link
Collaborator

IMO this is too granular a step for permissions. This then becomes permissions on actions per field type which raises a lot more questions re. dynamic zones should you be able to not reorder them etc?

@joshuaellis Still not being able to disable reodering to not get the reodering hit when somone moves the top to bottom or other way around and the hit is more then 30 seconds is to my opinion not exactable since that means that my whole aplication for anyone is not accasible for 30 seconds witout scaling if it is not more

@joshuaellis
Copy link
Member Author

IMO this is too granular a step for permissions. This then becomes permissions on actions per field type which raises a lot more questions re. dynamic zones should you be able to not reorder them etc?

@joshuaellis Still not being able to disable reodering to not get the reodering hit when somone moves the top to bottom or other way around and the hit is more then 30 seconds is to my opinion not exactable since that means that my whole aplication for anyone is not accasible for 30 seconds witout scaling if it is not more

We're at a difference in opinion. If you want to see this feature considered, then I would suggest you add it on Canny – https://strapi.canny.io/

@Boegie19
Copy link
Collaborator

@joshuaellis Me and @cpaczek just did a test if we have 10000 relationships and we reoder the 1000 relationship to 9999 then it takes 43000 for strapi since you give us the last added relationships in the view reordering any of them even by 1 has this impact So that means that any enterprise customer needs this disabled on there large relationships and we don't even have to click load more once also deleting 1 with 10000 relationships and you delete the 10000 relationship It takes 85 seconds to do so of the relationships has the same issue aka this would make strapi unusable for enterprise customers with large amount of relationships. Also I will write it out under the following issue with replication steps #15539 and explain it more

@joshuaellis
Copy link
Member Author

@joshuaellis Me and @cpaczek just did a test if we have 10000 relationships and we reoder the 1000 relationship to 9999 then it takes 43000 for strapi since you give us the last added relationships in the view reordering any of them even by 1 has this impact So that means that any enterprise customer needs this disabled on there large relationships and we don't even have to click load more once also deleting 1 with 10000 relationships and you delete the 10000 relationship It takes 85 seconds to do so of the relationships has the same issue aka this would make strapi unusable for enterprise customers with large amount of relationships. Also I will write it out under the following issue with replication steps #15539 and explain it more

We've discussed it internally this morning and to address your concerns above we're going to explore refining the FE payload & also investigate into #15539.

RE disabling the ability to re-order, like I said before if you want to see this included you should open a feature request.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr: feature This PR adds a new feature source: core:content-manager Source is core/content-manager package
Projects
None yet
7 participants