Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Can delete Public and Authenticated Roles from the UI even though it should be impossible #8262

Closed
devinv44 opened this issue Oct 9, 2020 · 0 comments · Fixed by #8272
Closed

Can delete Public and Authenticated Roles from the UI even though it should be impossible #8262

devinv44 opened this issue Oct 9, 2020 · 0 comments · Fixed by #8272

Comments

@devinv44
Copy link

devinv44 commented Oct 9, 2020

Describe the bug
The Public and Authenticated roles shouldn't be able to be deleted. I noticed that if you click in the same spot that the Trash icon would usually be the modal to delete the role still shows up. You can then click delete and the role is removed.

Steps to reproduce the behavior

  1. Go to "Settings > Users & Roles Permissions Plugin > Roles"
  2. Click next to the pencil icon on the Public or Authenticated icon (where the Trash icon would be for a role that can be deleted)

Expected behavior
I would expect nothing to happen. The modal shouldn't show up at all.

Screenshots
delete_non_deletable_role
MattieBelt added a commit to MattieBelt/strapi that referenced this issue Oct 10, 2020
@MattieBelt
Update roles listPage
87dca53 
Fixes strapi#8262

Signed-off-by: MattieBelt <mattiasvandenbelt@gmail.com>
MattieBelt added a commit to MattieBelt/strapi that referenced this issue Oct 10, 2020
@MattieBelt
Fix links action on role list page
fb53fad 
Fixes strapi#8262

Signed-off-by: MattieBelt <mattiasvandenbelt@gmail.com>
@MattieBelt MattieBelt mentioned this issue Oct 10, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix links action on role list page MattieBelt/strapi
1 participant
@devinv44