Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

French wording needs to be checked and clean (extra space) when adding a relational field to a CT in the CTB #8796

Closed
sam-pires opened this issue Dec 4, 2020 · 2 comments
Closed

French wording needs to be checked and clean (extra space) when adding a relational field to a CT in the CTB #8796

sam-pires opened this issue Dec 4, 2020 · 2 comments
Labels
good first issue Good for newcomers issue: bug Issue reporting a bug severity: low If the issue only affects a very niche base of users and an easily implemented workaround can solve source: core:content-type-builder Source is core/content-type-builder package

Comments

@sam-pires
Copy link
Contributor

sam-pires commented Dec 4, 2020 •
edited

Bug report

Describe the bug

There is an extra space in the French wording in the modal to add a single unilateral relation in the CTB. But I also wonder if the wording is actually correct: for the 2 first relationship types we use "[CT1] a un [CT2]".

See video: https://www.loom.com/share/95e8b07f2dff4dc3801624dd9d6bafc4

Steps to reproduce the behavior

  1. In dev env, Go to the CTB
  2. Put the Admin in French
  3. Open a CT
  4. Add a field, a relation
  5. Click on the 2 first types of relations and see error

Expected behavior

Regarding the extra space in the first relationship type: No extra space
Regarding the wording: See the comment below (cc @maevalienard )

System

  • Strapi version: 3.3
@sam-pires sam-pires added good first issue Good for newcomers severity: low If the issue only affects a very niche base of users and an easily implemented workaround can solve source: core:content-type-builder Source is core/content-type-builder package issue: bug Issue reporting a bug labels Dec 4, 2020
@maevalienard
Copy link

maevalienard commented Dec 4, 2020 •
edited

Thanks @sam-pires for bringing up this bug. I noticed actually the wording isn't correct in French for the 2nd, 3rd et 5th type of relation. Here are my propositions:

Capture d’écran 2020-12-04 à 12 07 06

"CT1 a et appartient à un CT2"

Capture d’écran 2020-12-04 à 12 07 09

"CT1 appartient à plusieurs CT2"

Capture d’écran 2020-12-04 à 12 10 52

"CT1 a et appartient à plusieurs CT2"

croatian91 added a commit to croatian91/strapi that referenced this issue Dec 16, 2020
@croatian91
Fix strapi#8796 - fix relation typo in fr
b7ffa00 
fix french translation in content type builder plugin
@croatian91
Copy link
Contributor

croatian91 commented Dec 16, 2020 •
edited

@maevalienard @sam-pires done! Please do check out the PR associated

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers issue: bug Issue reporting a bug severity: low If the issue only affects a very niche base of users and an easily implemented workaround can solve source: core:content-type-builder Source is core/content-type-builder package
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@croatian91 @sam-pires @maevalienard